From: Al Viro <viro@zeniv.linux.org.uk>
To: Jiangshan Yi <13667453960@163.com>,
akpm@linux-foundation.org, willy@infradead.org,
linux-kernel@vger.kernel.org,
Jiangshan Yi <yijiangshan@kylinos.cn>
Subject: Re: [PATCH] fs/efs/inode.c: use __func__ instead of function name
Date: Tue, 20 Sep 2022 01:52:36 +0100 [thread overview]
Message-ID: <YykO1A0CDGwsEDZT@ZenIV> (raw)
In-Reply-To: <YykLOUfit5r6cqxq@debian>
On Tue, Sep 20, 2022 at 08:37:13AM +0800, Gao Xiang wrote:
> On Tue, Sep 20, 2022 at 01:24:26AM +0100, Al Viro wrote:
> > On Mon, Sep 19, 2022 at 10:33:14AM +0800, Jiangshan Yi wrote:
> > > From: Jiangshan Yi <yijiangshan@kylinos.cn>
> > >
> > > It is better to use __func__ instead of function name.
> >
> > Why is it better? And why is it *not* sent to (active)
> > maintainers of fs/erofs? I'm not going to apply that behind their
> > backs and I would ask akpm to abstain from taking that one.
>
> It's efs although it also starts with letter e and ends with fs ;).
> I have no idea who actually takes care of it now.
*blink*
I plead obscenely low caffeine blood levels.
And I'm still not taking that patch - IMO that kind of stuff is absolutely
pointless from anyone other than active maintainers of some code;
the rationale for using __func__ is based upon the possibility of
function getting renamed, and that's not going to happen on inactive
codebase.
IOW, *if* somebody is starting a serious work in that area - sure, might
as well throw that kind of change in, as part of the series. Other than
that, though... No.
next prev parent reply other threads:[~2022-09-20 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 2:33 [PATCH] fs/efs/inode.c: use __func__ instead of function name Jiangshan Yi
2022-09-20 0:24 ` Al Viro
2022-09-20 0:37 ` Gao Xiang
2022-09-20 0:52 ` Al Viro [this message]
2022-09-21 9:52 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YykO1A0CDGwsEDZT@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=13667453960@163.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
--cc=yijiangshan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox