* [PATCH] fs/efs/inode.c: use __func__ instead of function name
@ 2022-09-19 2:33 Jiangshan Yi
2022-09-20 0:24 ` Al Viro
0 siblings, 1 reply; 5+ messages in thread
From: Jiangshan Yi @ 2022-09-19 2:33 UTC (permalink / raw)
To: akpm, viro; +Cc: willy, linux-kernel, Jiangshan Yi
From: Jiangshan Yi <yijiangshan@kylinos.cn>
It is better to use __func__ instead of function name.
Signed-off-by: Jiangshan Yi <yijiangshan@kylinos.cn>
---
fs/efs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/efs/inode.c b/fs/efs/inode.c
index 3ba94bb005a6..ba15c7d66adc 100644
--- a/fs/efs/inode.c
+++ b/fs/efs/inode.c
@@ -141,8 +141,8 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino)
}
brelse(bh);
- pr_debug("efs_iget(): inode %lu, extents %d, mode %o\n",
- inode->i_ino, in->numextents, inode->i_mode);
+ pr_debug("%s(): inode %lu, extents %d, mode %o\n",
+ __func__, inode->i_ino, in->numextents, inode->i_mode);
switch (inode->i_mode & S_IFMT) {
case S_IFDIR:
inode->i_op = &efs_dir_inode_operations;
--
2.27.0
No virus found
Checked by Hillstone Network AntiVirus
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] fs/efs/inode.c: use __func__ instead of function name
2022-09-19 2:33 [PATCH] fs/efs/inode.c: use __func__ instead of function name Jiangshan Yi
@ 2022-09-20 0:24 ` Al Viro
2022-09-20 0:37 ` Gao Xiang
2022-09-21 9:52 ` David Laight
0 siblings, 2 replies; 5+ messages in thread
From: Al Viro @ 2022-09-20 0:24 UTC (permalink / raw)
To: Jiangshan Yi; +Cc: akpm, willy, linux-kernel, Jiangshan Yi
On Mon, Sep 19, 2022 at 10:33:14AM +0800, Jiangshan Yi wrote:
> From: Jiangshan Yi <yijiangshan@kylinos.cn>
>
> It is better to use __func__ instead of function name.
Why is it better? And why is it *not* sent to (active)
maintainers of fs/erofs? I'm not going to apply that behind their
backs and I would ask akpm to abstain from taking that one.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fs/efs/inode.c: use __func__ instead of function name
2022-09-20 0:24 ` Al Viro
@ 2022-09-20 0:37 ` Gao Xiang
2022-09-20 0:52 ` Al Viro
2022-09-21 9:52 ` David Laight
1 sibling, 1 reply; 5+ messages in thread
From: Gao Xiang @ 2022-09-20 0:37 UTC (permalink / raw)
To: Al Viro; +Cc: Jiangshan Yi, akpm, willy, linux-kernel, Jiangshan Yi
On Tue, Sep 20, 2022 at 01:24:26AM +0100, Al Viro wrote:
> On Mon, Sep 19, 2022 at 10:33:14AM +0800, Jiangshan Yi wrote:
> > From: Jiangshan Yi <yijiangshan@kylinos.cn>
> >
> > It is better to use __func__ instead of function name.
>
> Why is it better? And why is it *not* sent to (active)
> maintainers of fs/erofs? I'm not going to apply that behind their
> backs and I would ask akpm to abstain from taking that one.
It's efs although it also starts with letter e and ends with fs ;).
I have no idea who actually takes care of it now.
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fs/efs/inode.c: use __func__ instead of function name
2022-09-20 0:37 ` Gao Xiang
@ 2022-09-20 0:52 ` Al Viro
0 siblings, 0 replies; 5+ messages in thread
From: Al Viro @ 2022-09-20 0:52 UTC (permalink / raw)
To: Jiangshan Yi, akpm, willy, linux-kernel, Jiangshan Yi
On Tue, Sep 20, 2022 at 08:37:13AM +0800, Gao Xiang wrote:
> On Tue, Sep 20, 2022 at 01:24:26AM +0100, Al Viro wrote:
> > On Mon, Sep 19, 2022 at 10:33:14AM +0800, Jiangshan Yi wrote:
> > > From: Jiangshan Yi <yijiangshan@kylinos.cn>
> > >
> > > It is better to use __func__ instead of function name.
> >
> > Why is it better? And why is it *not* sent to (active)
> > maintainers of fs/erofs? I'm not going to apply that behind their
> > backs and I would ask akpm to abstain from taking that one.
>
> It's efs although it also starts with letter e and ends with fs ;).
> I have no idea who actually takes care of it now.
*blink*
I plead obscenely low caffeine blood levels.
And I'm still not taking that patch - IMO that kind of stuff is absolutely
pointless from anyone other than active maintainers of some code;
the rationale for using __func__ is based upon the possibility of
function getting renamed, and that's not going to happen on inactive
codebase.
IOW, *if* somebody is starting a serious work in that area - sure, might
as well throw that kind of change in, as part of the series. Other than
that, though... No.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] fs/efs/inode.c: use __func__ instead of function name
2022-09-20 0:24 ` Al Viro
2022-09-20 0:37 ` Gao Xiang
@ 2022-09-21 9:52 ` David Laight
1 sibling, 0 replies; 5+ messages in thread
From: David Laight @ 2022-09-21 9:52 UTC (permalink / raw)
To: 'Al Viro', Jiangshan Yi
Cc: akpm@linux-foundation.org, willy@infradead.org,
linux-kernel@vger.kernel.org, Jiangshan Yi
From: Al Viro
> Sent: 20 September 2022 01:24
>
> On Mon, Sep 19, 2022 at 10:33:14AM +0800, Jiangshan Yi wrote:
> > From: Jiangshan Yi <yijiangshan@kylinos.cn>
> >
> > It is better to use __func__ instead of function name.
>
> Why is it better? And why is it *not* sent to (active)
> maintainers of fs/erofs? I'm not going to apply that behind their
> backs and I would ask akpm to abstain from taking that one.
It is distinctly worse.
Anyone grepping the kernel source for the message text will
fail to find it.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-21 9:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-19 2:33 [PATCH] fs/efs/inode.c: use __func__ instead of function name Jiangshan Yi
2022-09-20 0:24 ` Al Viro
2022-09-20 0:37 ` Gao Xiang
2022-09-20 0:52 ` Al Viro
2022-09-21 9:52 ` David Laight
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox