From: Lee Jones <lee@kernel.org>
To: Sebastian Urban <surban@surban.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: take OF node reference for MFD cell platform device
Date: Tue, 20 Sep 2022 10:25:47 +0100 [thread overview]
Message-ID: <YymHG4OmMktrRqof@google.com> (raw)
In-Reply-To: <20220917094132.458194-1-surban@surban.net>
On Sat, 17 Sep 2022, Sebastian Urban wrote:
> Properly increase OF node reference count when assigning it to a
> platform device created for an MFD cell.
>
> Signed-off-by: Sebastian Urban <surban@surban.net>
> ---
> drivers/mfd/mfd-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 16d1861e9682..8e57f67719cf 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -161,7 +161,7 @@ static int mfd_match_of_node_to_dev(struct platform_device *pdev,
> of_entry->np = np;
> list_add_tail(&of_entry->list, &mfd_of_node_list);
>
> - pdev->dev.of_node = np;
> + pdev->dev.of_node = of_node_get(np);
Doesn't this cause an imbalance?
Or is there already a put somewhere?
> pdev->dev.fwnode = &np->fwnode;
> #endif
> return 0;
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-09-20 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 9:41 [PATCH] mfd: take OF node reference for MFD cell platform device Sebastian Urban
2022-09-20 9:25 ` Lee Jones [this message]
2022-10-18 9:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YymHG4OmMktrRqof@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surban@surban.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox