From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Longfang Liu <liulongfang@huawei.com>,
shameerali.kolothum.thodi@huawei.com, cohuck@redhat.com,
linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH 1/5] hisi_acc_vfio_pci: Fixes a memory leak bug
Date: Tue, 20 Sep 2022 13:38:18 -0300 [thread overview]
Message-ID: <YynsesGyvJl26jDI@nvidia.com> (raw)
In-Reply-To: <20220920103443.72654dd7.alex.williamson@redhat.com>
On Tue, Sep 20, 2022 at 10:34:43AM -0600, Alex Williamson wrote:
> On Thu, 15 Sep 2022 09:31:53 +0800
> Longfang Liu <liulongfang@huawei.com> wrote:
>
> > During the stop copy phase of live migration, the driver allocates
> > a memory for the migrated data to save the data.
> >
> > When an exception occurs when the driver reads device data, the driver
> > will report an error to qemu and exit the current migration state.
> > But this memory is not released, which will lead to a memory
> > leak problem.
Why isn't it released? The fput() releases it:
static int hisi_acc_vf_release_file(struct inode *inode, struct file *filp)
{
struct hisi_acc_vf_migration_file *migf = filp->private_data;
hisi_acc_vf_disable_fd(migf);
mutex_destroy(&migf->lock);
kfree(migf);
^^^^^^^^^^
This patch looks wrong to me.
Jason
next prev parent reply other threads:[~2022-09-20 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 1:31 [PATCH 0/5] Fix some bugs and clean code issues Longfang Liu
2022-09-15 1:31 ` [PATCH 1/5] hisi_acc_vfio_pci: Fixes a memory leak bug Longfang Liu
2022-09-20 16:34 ` Alex Williamson
2022-09-20 16:38 ` Jason Gunthorpe [this message]
2022-09-20 17:03 ` Shameerali Kolothum Thodi
2022-09-21 3:13 ` liulongfang
2022-09-21 7:27 ` Shameerali Kolothum Thodi
2022-09-22 7:51 ` liulongfang
2022-09-15 1:31 ` [PATCH 2/5] hisi_acc_vfio_pci: Fixes error return code issue Longfang Liu
2022-09-15 1:31 ` [PATCH 3/5] hisi_acc_vfio_pci: Remove useless function parameter Longfang Liu
2022-09-15 1:31 ` [PATCH 4/5] hisi_acc_vfio_pci: Fix device data address combination problem Longfang Liu
2022-09-15 1:31 ` [PATCH 5/5] hisi_acc_vfio_pci: Fix some clean code issues Longfang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YynsesGyvJl26jDI@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=liulongfang@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox