From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83741ECAAD8 for ; Tue, 20 Sep 2022 16:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231352AbiITQms (ORCPT ); Tue, 20 Sep 2022 12:42:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiITQmp (ORCPT ); Tue, 20 Sep 2022 12:42:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF3353ECC6 for ; Tue, 20 Sep 2022 09:42:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5CE42624D3 for ; Tue, 20 Sep 2022 16:42:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E72C2C433C1; Tue, 20 Sep 2022 16:42:41 +0000 (UTC) Date: Tue, 20 Sep 2022 17:42:38 +0100 From: Catalin Marinas To: James Clark Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, Alexander Shishkin , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coresight: Use new autogenerated sysreg definitions Message-ID: References: <20220920134827.31738-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920134827.31738-1-james.clark@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 02:48:27PM +0100, James Clark wrote: > Fix the build by updating registers to use the new autogenerated format. > > Fixes: c0357a73fa4a ("arm64/sysreg: Align field names in ID_AA64DFR0_EL1 with architecture") > Signed-off-by: James Clark In general it's better to add the build error in the commit log. I'll add one as I can reproduce it. Since it's broken by the arm64 tree, I plan to add it to the same branch (for-next/sysreg). BTW, for some reason we don't have CoreSight enabled in defconfig, not even as a module. Would you mind sending a patch for this and enable (as modules) all the relevant drivers? We miss any test coverage here. Thanks. -- Catalin