From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932CDC6FA82 for ; Tue, 20 Sep 2022 18:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbiITSI2 (ORCPT ); Tue, 20 Sep 2022 14:08:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbiITSIZ (ORCPT ); Tue, 20 Sep 2022 14:08:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9172F65279 for ; Tue, 20 Sep 2022 11:08:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F06962BD5 for ; Tue, 20 Sep 2022 18:08:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DAA7C433C1; Tue, 20 Sep 2022 18:08:20 +0000 (UTC) Date: Tue, 20 Sep 2022 19:08:16 +0100 From: Catalin Marinas To: Mark Brown Cc: James Clark , suzuki.poulose@arm.com, coresight@lists.linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, Alexander Shishkin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coresight: Use new autogenerated sysreg definitions Message-ID: References: <20220920134827.31738-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 06:56:59PM +0100, Mark Brown wrote: > On Tue, Sep 20, 2022 at 06:07:34PM +0100, Catalin Marinas wrote: > > On Tue, Sep 20, 2022 at 05:42:38PM +0100, Catalin Marinas wrote: > > > BTW, for some reason we don't have CoreSight enabled in defconfig, not > > > even as a module. Would you mind sending a patch for this and enable (as > > > modules) all the relevant drivers? We miss any test coverage here. > > > > The PMU counters are in the same camp. Enabling them breaks the kernel > > build. I wonder whether we should go for changing the default in Kconfig > > directly rather than defconfig. > > I sent a patch for the PMU counters defconfig yesterday. The defconfig patches tend to fall through the cracks. I'll try to pick some of them up. BTW, do you plan to send a patch for the arm_spe_pmu build failures (unless you did already and I missed it): linux/drivers/perf/arm_spe_pmu.c: In function 'arm_spe_pmsevfr_res0': linux/drivers/perf/arm_spe_pmu.c:677:14: error: 'ID_AA64DFR0_PMSVER_8_2' undeclared (first use in this function); did you mean 'ID_AA64DFR0_EL1_PMSVer_IMP'? 677 | case ID_AA64DFR0_PMSVER_8_2: | ^~~~~~~~~~~~~~~~~~~~~~ | ID_AA64DFR0_EL1_PMSVer_IMP linux/drivers/perf/arm_spe_pmu.c:677:14: note: each undeclared identifier is reported only once for each function it appears in linux/drivers/perf/arm_spe_pmu.c:679:14: error: 'ID_AA64DFR0_PMSVER_8_3' undeclared (first use in this function); did you mean 'ID_AA64DFR0_EL1_PMSVer_IMP'? 679 | case ID_AA64DFR0_PMSVER_8_3: | ^~~~~~~~~~~~~~~~~~~~~~ | ID_AA64DFR0_EL1_PMSVer_IMP linux/drivers/perf/arm_spe_pmu.c: In function '__arm_spe_pmu_dev_probe': linux/drivers/perf/arm_spe_pmu.c:961:52: error: 'ID_AA64DFR0_PMSVER_SHIFT' undeclared (first use in this function); did you mean 'ID_AA64DFR0_EL1_PMSVer_SHIFT'? 961 | ID_AA64DFR0_PMSVER_SHIFT); | ^~~~~~~~~~~~~~~~~~~~~~~~ | ID_AA64DFR0_EL1_PMSVer_SHIFT -- Catalin