From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A95EC32771 for ; Wed, 21 Sep 2022 06:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbiIUGsV (ORCPT ); Wed, 21 Sep 2022 02:48:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229787AbiIUGsS (ORCPT ); Wed, 21 Sep 2022 02:48:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B45F80F62; Tue, 20 Sep 2022 23:48:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 07D2F6216B; Wed, 21 Sep 2022 06:48:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61A4DC433C1; Wed, 21 Sep 2022 06:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663742896; bh=TvyVP6RlE55q2MwRdD1Tyx/Kp0Yj7xC9kH/TAmfA2Vc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VwlyA/O05Nj92M8e0nW2ptnU1oYJr+7dMoKfxx537bMl8DnM13RJRa5upM4TAb632 QpaPJv0n8+raAoQnRaoPE4NOoWvs5JSPGQ1Y+97xl/WBkfiiE9Se0F0Iad7T6fGOu6 2yyj1VqbE3/66dK7QRjVtJS4K39wg+V9ACgobCGTKzKLCIRrR+Qjvl4QgzITe8Smwy Ov3JSSZDxtAm5K5Dj7rpg9xdowCP/Sb4r8/Xn69ogGra2TiPwjEwD7L1QRBr89Tw2o +vPUT3SWagCj/X5sgzA1pFMM8/G6lYmObCaZCOz61A4WH/zUV8izVWHnxStR/6ctT2 GO78jX5Wb5soQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oatWr-0003a9-MX; Wed, 21 Sep 2022 08:48:17 +0200 Date: Wed, 21 Sep 2022 08:48:17 +0200 From: Johan Hovold To: Parikshit Pareek Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney , Shazad Hussain Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi Message-ID: References: <20220920120802.14321-1-quic_ppareek@quicinc.com> <20220920120802.14321-3-quic_ppareek@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920120802.14321-3-quic_ppareek@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 05:38:01PM +0530, Parikshit Pareek wrote: > There are many ADP boards with lot of common features. Move common > nodes to sa8540p-adp.dtsi file. This will be base for many ADP boards > to be introduced in near future. I already asked you to include a description of those differences here in the commit message so that we can make a decision on whether this change makes sense or not. This also needs to be documented for future changes. For example, when I'll be adding PCIe support to sa8295p-adp I'd need to know whether this should go in a shared dtsi or in the board file. For reasons like this, I'm still not convinced that this is a good idea. > Signed-off-by: Parikshit Pareek > --- > arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +----------------- > .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0 > 2 files changed, 14 insertions(+), 378 deletions(-) > rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%) > copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%) Johan