From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Lennert Buytenhek <buytenh@wantstofly.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Alex Williamson <alex.williamson@hp.com>,
Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Lennert Buytenhek <buytenh@arista.com>
Subject: Re: [PATCH v3 1/1] serial: 8250: Toggle IER bits on only after irq has been set up
Date: Wed, 21 Sep 2022 18:00:04 +0300 [thread overview]
Message-ID: <Yysm9ALLsXk3oYRt@smile.fi.intel.com> (raw)
In-Reply-To: <24ec3f1f-b39c-eeb1-d53-ed97e2ccdb4f@linux.intel.com>
On Wed, Sep 21, 2022 at 04:20:50PM +0300, Ilpo Järvinen wrote:
> On Mon, 19 Sep 2022, Ilpo Järvinen wrote:
...
> > - retval = up->ops->setup_irq(up);
> > - if (retval)
> > - goto out;
> > + univ8250_setup_timer(up);
> Please scratch this patch. It seems to create a circular dependency issue
> with allmodconfig. I'll send v4 once the problem is sorted out.
In accordance with what you told me privately, I think you will need yet
another ops, i.e. ->setup_timer().
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-09-21 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 14:40 [PATCH v3 1/1] serial: 8250: Toggle IER bits on only after irq has been set up Ilpo Järvinen
2022-09-21 13:20 ` Ilpo Järvinen
2022-09-21 15:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yysm9ALLsXk3oYRt@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@hp.com \
--cc=aris@cathedrallabs.org \
--cc=buytenh@arista.com \
--cc=buytenh@wantstofly.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox