Re: [PATCH 1/1] arm64: defconfig: Add Coresight as module

James Clark
2022-09-22T09:04:19Z

On 21/09/2022 17:46, Mathieu Poirier wrote:
> On Wed, Sep 21, 2022 at 04:26:59PM +0100, Mark Brown wrote:
>> On Wed, Sep 21, 2022 at 03:05:35PM +0100, James Clark wrote:
>>
>>> +CONFIG_CORESIGHT_CTI=m
>>> +CONFIG_CORESIGHT_CTI_INTEGRATION_REGS=y
>>
>
> I agree - integration registers should not be enabled by default.
>
>> Do we want this turned on by default? According to the
>> description it's a bit dangerous and it's exposed via sysfs
>> rather than debugfs.
>
>

Should I disable just CONFIG_CORESIGHT_CTI_INTEGRATION_REGS or
CONFIG_CORESIGHT_CTI as well? There are other writable registers exposed
via sysfs outside of these two options, so I wanted to check if it's
just the integration registers that are the issue.