From: Conor Dooley <conor@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andre Przywara <andre.przywara@arm.com>,
Conor Dooley <conor.dooley@microchip.com>,
Samuel Holland <samuel@sholland.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Atish Patra <atishp@atishpatra.org>,
"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Subject: Re: Similar SoCs with different CPUs and interrupt bindings
Date: Wed, 21 Sep 2022 22:05:55 +0100 [thread overview]
Message-ID: <Yyt8s5+pyoysVNeC@spud> (raw)
In-Reply-To: <CAMuHMdXaWz4zP-Zrc4drxwVmbMjmGZHABVbUtO91fZXKawathw@mail.gmail.com>
On Wed, Sep 21, 2022 at 12:08:11PM +0200, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> > > This worked as expected, but couldn't get the arithmetic operation
> > > working. Could you please provide an example?
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> > index ff6aab388eb7..0ecca775fa3f 100644
> > --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> > @@ -8,6 +8,8 @@
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/r9a07g043-cpg.h>
> >
> > +#define SOC_PERIPHERAL_IRQ_NUMBER(na) (na + 32)
> > +#define SOC_PERIPHERAL_IRQ(nr, na) GIC_SPI nr SOC_PERIPHERAL_IRQ_NUMBER(na)
>
> #define SOC_PERIPHERAL_IRQ(nr, flags) GIC_SPI
> SOC_PERIPHERAL_IRQ_NUMBER(nr) flags
>
> > / {
> > compatible = "renesas,r9a07g043";
> > #address-cells = <2>;
> > @@ -128,7 +130,7 @@ ssi1: ssi@1004a000 {
> > compatible = "renesas,r9a07g043-ssi",
> > "renesas,rz-ssi";
> > reg = <0 0x1004a000 0 0x400>;
> > - interrupts = <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>,
> > + interrupts = <SOC_PERIPHERAL_IRQ(330, IRQ_TYPE_LEVEL_HIGH)>,
> >
> >
> >
> > Or any other method like that....
>
> Oh cool, seems like arithmetic is supported.
> No idea what I did wrong last time I tried...
Oh sick, it does actually work??? So, am I missing something or is this
sort of approach now a no-brainer?
next prev parent reply other threads:[~2022-09-21 21:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 7:46 Similar SoCs with different CPUs and interrupt bindings Geert Uytterhoeven
2022-09-21 8:49 ` Krzysztof Kozlowski
2022-09-21 9:20 ` Lad, Prabhakar
2022-09-21 9:26 ` Krzysztof Kozlowski
2022-09-21 10:07 ` Lad, Prabhakar
2022-09-21 10:08 ` Geert Uytterhoeven
2022-09-21 10:10 ` Krzysztof Kozlowski
2022-09-21 21:05 ` Conor Dooley [this message]
2022-09-21 10:14 ` Robin Murphy
2022-09-21 10:17 ` Krzysztof Kozlowski
2022-09-21 10:27 ` Robin Murphy
2022-09-21 10:10 ` Geert Uytterhoeven
2022-09-21 9:20 ` Robin Murphy
2022-09-21 10:13 ` Geert Uytterhoeven
2022-09-21 10:20 ` Krzysztof Kozlowski
2022-09-22 6:30 ` Arnd Bergmann
2022-09-22 6:40 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyt8s5+pyoysVNeC@spud \
--to=conor@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=andre.przywara@arm.com \
--cc=arnd@arndb.de \
--cc=atishp@atishpatra.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=olof@lixom.net \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox