From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A50C6FA82 for ; Wed, 21 Sep 2022 17:55:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiIURzW (ORCPT ); Wed, 21 Sep 2022 13:55:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbiIURzT (ORCPT ); Wed, 21 Sep 2022 13:55:19 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21FF1578A0 for ; Wed, 21 Sep 2022 10:55:19 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id q15-20020a17090a304f00b002002ac83485so6762964pjl.0 for ; Wed, 21 Sep 2022 10:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=6zseYLWfMQl699NSYlSkulwSYga25k2VOd8kmGGDZqA=; b=HF1GO28QnOsgPyjvlZwBtrm8nRj4a37NZoVS5Xs0nafeLYz+REY6KzOMOqDMAc6b80 dG6jVcE6eQEy5LLzzS2cWLwJkcassxeNo4cZPl5DUBJOj/T0/NtYkygSddZwMxt+ZYlT POUtRHieTNX1aRGfes8sNIWUztwqlANp9phuRT/KPG+LfmT4VFuPHLToJtlx8W5Dr3m6 cAFui5GQyLeZf2ewtNQLjaBQBmSFgn+lQamAp2KtpFI0x0Tr50LCAgL839BhOcMb1Rs3 1ttPdFRElrOpKnKxF05T/ZsA4xD/4kfEIlCq7eqiTQbFx/mDTMwrbOF2TxB25WQcjwRL X02w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=6zseYLWfMQl699NSYlSkulwSYga25k2VOd8kmGGDZqA=; b=ibF/8a/wb85awM9xA5OrbU+bAMVBkuDhwB+qfmKC65Nr6tHODB6qco7qEdydCdz+uh UotYx4xuMEgmkLQptEHwVt9CBnhfjbZV5alX0GBINfpTSpSeALg86O8Z2/uSQGD/ywAx itGyiRKKTUhO6F8II+HUXMRKo+rhH7KT7IdC6WkD35pPf+xRSUbMu/bieRyK7bNDy0iU 6eqhYkx6HWdm6lLTnBOZ6In6dQpuTho0x0ONE99oEGkyDq7NCV+ew3DU+zxOigPf9X4V JYzbkiPHXOCKRq9r5cwDPoJ3XvXJ4JNpTRapmNcZU0RZpBzg+AOomMaKIEzcOLGzJAdV iijw== X-Gm-Message-State: ACrzQf3QvR3tlZyubOmx93vwQjZsRN2qbgyRTAoyITmIpvQit8MLyqUw Cd1Pe2H31lzAt38mOowyMsCZyg== X-Google-Smtp-Source: AMsMyM7JRMOlfWKYd/bO5/MnMIvgz5EQcEWb9H8mLgiVoQ7Y7kgRGUJn9FoE0EMYZb98seiF60t5vw== X-Received: by 2002:a17:90a:e7c5:b0:200:ab1a:f32 with SMTP id kb5-20020a17090ae7c500b00200ab1a0f32mr10602649pjb.100.1663782918084; Wed, 21 Sep 2022 10:55:18 -0700 (PDT) Received: from google.com (223.103.125.34.bc.googleusercontent.com. [34.125.103.223]) by smtp.gmail.com with ESMTPSA id l25-20020a635b59000000b0043395af24f6sm2221034pgm.25.2022.09.21.10.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 10:55:17 -0700 (PDT) Date: Wed, 21 Sep 2022 10:55:13 -0700 From: David Matlack To: Vipin Sharma Cc: seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] KVM: selftests: Explicitly set variables based on options in dirty_log_perf_test Message-ID: References: <20220826184500.1940077-1-vipinsh@google.com> <20220826184500.1940077-2-vipinsh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 02:12:49PM -0700, Vipin Sharma wrote: > On Fri, Aug 26, 2022 at 11:45 AM Vipin Sharma wrote: > > > > Variable set via -g are also indirectly set by -e option by omitting > > break statement. Set them explicitly so that movement of switch-case > > statements does not unintentionally break features. > > > > No functional change intended. > > > > Signed-off-by: Vipin Sharma > > --- > > tools/testing/selftests/kvm/dirty_log_perf_test.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > > index f99e39a672d3..a03db7f9f4c0 100644 > > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > > @@ -411,6 +411,8 @@ int main(int argc, char *argv[]) > > case 'e': > > /* 'e' is for evil. */ > > run_vcpus_while_disabling_dirty_logging = true; > > + dirty_log_manual_caps = 0; > > + break; > > @Sean, I hope you intentionally didn't write a break between -e and -g > when you created the patch and it is not just a missed thing :) I'm pretty sure the missing break here is by accident. If it was on purpose I would expect Sean (especially) to have called it out the subtle change in the commit message and probably add a comment here. Also I can't think of any reason why run_vcpus_while_disabling_dirty_logging=true would require dirty_log_manual_caps=0. Can you change this patch to just add a break and add a fixes tag to the commit message? Fixes: cfe12e64b065 ("KVM: selftests: Add an option to run vCPUs while disabling dirty logging") > > > > case 'g': > > dirty_log_manual_caps = 0; > > break; > > -- > > 2.37.2.672.g94769d06f0-goog > >