From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50832C54EE9 for ; Thu, 22 Sep 2022 11:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231572AbiIVLPb (ORCPT ); Thu, 22 Sep 2022 07:15:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231546AbiIVLPW (ORCPT ); Thu, 22 Sep 2022 07:15:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9B133FA25; Thu, 22 Sep 2022 04:15:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EBB80B835E0; Thu, 22 Sep 2022 11:15:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1DB1C4347C; Thu, 22 Sep 2022 11:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663845305; bh=HJLF0sxaaK0zibNfx1kSIE8o0oMxLWdBFj2lY98C4Is=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=meHPgX7O07DcuZq2IoD9HWIbHP7eoS5UilZv6q9TrjGj1n19t3QGF1ETE3tU1X1/A m4YpNcgt4ydOBvSoaHoFAWTSFN09F5NpXe1V9W+noau3MsiJJcutaXiIcWy/YZsbSn UnREWAMsskqMqYNyVlpxpyx8JKCshTQpXl9uXIII= Date: Thu, 22 Sep 2022 13:15:02 +0200 From: Greg KH To: David Gow Cc: cgel.zte@gmail.com, Brendan Higgins , paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, Shuah Khan , Daniel Latypov , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , linux-riscv , Linux Kernel Mailing List , Xu Panda , Zeal Robot Subject: Re: [PATCH linux-next] kunit: tool: use absolute path for wget Message-ID: References: <20220922083610.235936-1-xu.panda@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2022 at 06:50:59PM +0800, David Gow wrote: > On Thu, Sep 22, 2022 at 6:20 PM Greg KH wrote: > > > > On Thu, Sep 22, 2022 at 06:09:28PM +0800, David Gow wrote: > > > On Thu, Sep 22, 2022 at 4:36 PM wrote: > > > > > > > > From: Xu Panda > > > > > > > > Not using absolute path when invoking wget can lead to serious > > > > security issues. > > > > > > > > Reported-by: Zeal Robot > > > > Signed-off-by: Xu Panda > > > > --- > > > > > > This seems mostly okay to me -- we'd be abandoning people who have > > > wget in an unusual location, but I don't think there are many people > > > who want to run KUnit under RISC-V, have wget in a non-standard > > > location, and can't acquire the bios file themselves. > > > > > > So this is: > > > Reviewed-by: David Gow > > > > Please no, at this point in time, submissions from this gmail "alias" > > are going to have to be rejected from the kernel. > > > > Good to know, thanks. > > This isn't queued anyway, as I think that getting rid of the code to > download the BIOS (and instead relying on the user's distro to provide > it) is probably a better solution.s That's a much better solution, we have authenticated firmware download paths for BIOS images on Linux now integrated into distros. Let's use that infrastructure that is set up for that for this type of thing. thanks, greg k-h