public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org,
	Andreas Noever <andreas.noever@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	sanju.mehta@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix some hotplug event issues
Date: Thu, 22 Sep 2022 14:34:40 +0300	[thread overview]
Message-ID: <YyxIUDIZM23tzmhg@black.fi.intel.com> (raw)
In-Reply-To: <6283792d-3c91-0ec2-6f2b-edd647d0de67@amd.com>

Hi Mario,

On Wed, Sep 21, 2022 at 10:48:17AM -0500, Limonciello, Mario wrote:
> On 9/21/2022 10:45, Greg KH wrote:
> > On Wed, Sep 21, 2022 at 09:54:31AM -0500, Mario Limonciello wrote:
> > > On AMD Pink Sardine it's been observed that if another CM has run before
> > > the Linux CM that some registers may not match expectations which leads
> > > to a non-functional hotplug for PCIe devices.
> > > 
> > > Explicitly set these registers that have been observed to cause problems
> > > with hotplug to the defaults of the USB4 spec.
> > > 
> > > Mario Limonciello (2):
> > >    thunderbolt: Explicitly reset plug events delay back to USB4 spec
> > >      value
> > >    thunderbolt: Explicitly enable lane adapter hotplug events at startup
> > > 
> > >   drivers/thunderbolt/switch.c  |  5 +++++
> > >   drivers/thunderbolt/tb.h      |  1 +
> > >   drivers/thunderbolt/tb_regs.h |  1 +
> > >   drivers/thunderbolt/usb4.c    | 19 +++++++++++++++++++
> > >   4 files changed, 26 insertions(+)
> > 
> > Any specific reason these were not tagged for stable backports?
> > 
> > thanks,
> > 
> > greg k-h
> 
> 
> No; no particular reason.  If Mika agrees with them, I think they are good
> candidates to include for stable too.  If I respin them, I'll tag
> accordingly.  If Mika picks them up as v1 I think he can add the tag when
> committing them.

I applied the first one to my fixes branch and tagged it for stable. For
the second one, I have a couple of comments that I would like you to
address (sent in a separate email) ;-)


      reply	other threads:[~2022-09-22 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 14:54 [PATCH 0/2] Fix some hotplug event issues Mario Limonciello
2022-09-21 14:54 ` [PATCH 1/2] thunderbolt: Explicitly reset plug events delay back to USB4 spec value Mario Limonciello
2022-09-21 14:54 ` [PATCH 2/2] thunderbolt: Explicitly enable lane adapter hotplug events at startup Mario Limonciello
2022-09-22 11:30   ` Mika Westerberg
2022-09-21 15:45 ` [PATCH 0/2] Fix some hotplug event issues Greg KH
2022-09-21 15:48   ` Limonciello, Mario
2022-09-22 11:34     ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyxIUDIZM23tzmhg@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=michael.jamet@intel.com \
    --cc=sanju.mehta@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox