From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Slaby" <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_dma: Convert to use uart_xmit_advance()
Date: Thu, 22 Sep 2022 16:10:58 +0200 [thread overview]
Message-ID: <Yyxs8o7tB6BVS0Kt@kroah.com> (raw)
In-Reply-To: <20220909091102.58941-1-andriy.shevchenko@linux.intel.com>
On Fri, Sep 09, 2022 at 12:11:02PM +0300, Andy Shevchenko wrote:
> uart_xmit_advance() provides a common way on how to advance
> the Tx queue. Use it for the sake of unification and robustness.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_dma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c
> index d99020fd3427..b85c82616e8c 100644
> --- a/drivers/tty/serial/8250/8250_dma.c
> +++ b/drivers/tty/serial/8250/8250_dma.c
> @@ -26,9 +26,7 @@ static void __dma_tx_complete(void *param)
>
> dma->tx_running = 0;
>
> - xmit->tail += dma->tx_size;
> - xmit->tail &= UART_XMIT_SIZE - 1;
> - p->port.icount.tx += dma->tx_size;
> + uart_xmit_advance(&p->port, dma->tx_size);
>
> if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
> uart_write_wakeup(&p->port);
> --
> 2.35.1
>
Breaks the build :(
next prev parent reply other threads:[~2022-09-22 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 9:11 [PATCH v1 1/1] serial: 8250_dma: Convert to use uart_xmit_advance() Andy Shevchenko
2022-09-09 9:16 ` Ilpo Järvinen
2022-09-09 10:17 ` Andy Shevchenko
2022-09-22 14:10 ` Greg Kroah-Hartman [this message]
2022-09-22 14:24 ` Ilpo Järvinen
2022-09-22 14:33 ` Greg Kroah-Hartman
2022-09-22 15:03 ` Andy Shevchenko
2022-09-25 7:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyxs8o7tB6BVS0Kt@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox