From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>, linux-kernel@vger.kernel.org
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH v1 1/1] cpumask: Don't waste memory for sysfs cpulist nodes
Date: Thu, 22 Sep 2022 22:46:48 +0300 [thread overview]
Message-ID: <Yyy7qPXmIrL2TraY@smile.fi.intel.com> (raw)
In-Reply-To: <20220922193447.88123-1-andriy.shevchenko@linux.intel.com>
On Thu, Sep 22, 2022 at 10:34:47PM +0300, Andy Shevchenko wrote:
> Currently the approximation is used which wastes the more memory
> the more CPUs are present on the system. Proposed change calculates
> the exact maximum needed in the worst case:
>
> NR_CPUS old new
> ------- --- ---
> 1 .. 1860 4096 4096
> ... ... ...
> 2*4096 28672 19925
> 4*4096 57344 43597
> 8*4096 114688 92749
> 16*4096 229376 191053
> 32*4096 458752 403197
> 64*4096 917504 861949
> 128*4096 1835008 1779453
> 256*4096 3670016 3670016
>
> Under the hood the reccurent formula is being used:
> (5 - 0) * 2 +
> (50 - 5) * 3 +
> (500 - 50) * 4 +
> (5000 - 500) * 5 +
> ...
> (X[i] - X[i-1]) * i
>
> which allows to count the exact maximum length in the worst case,
> i.e. when each second CPU is being listed. For less than 1861 and
> more than 1 million CPUs the old is being used.
Scratch this because for the range 1171..1860 the new is better,
I'll update commit message and comment in v2 sending soon.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-09-22 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 19:34 [PATCH v1 1/1] cpumask: Don't waste memory for sysfs cpulist nodes Andy Shevchenko
2022-09-22 19:46 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyy7qPXmIrL2TraY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pauld@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox