From: Corey Minyard <minyard@acm.org>
To: Xiu Jianfeng <xiujianfeng@huawei.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Add __init/__exit annotations to module init/exit funcs
Date: Thu, 22 Sep 2022 10:56:22 -0500 [thread overview]
Message-ID: <YyyFphRSkO4roYlk@minyard.net> (raw)
In-Reply-To: <20220922111924.36044-1-xiujianfeng@huawei.com>
On Thu, Sep 22, 2022 at 07:19:24PM +0800, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
Applied, thanks.
-corey
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> drivers/char/ipmi/ipmi_ssif.c | 4 ++--
> drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 4 ++--
> drivers/char/ipmi/kcs_bmc_serio.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 13da021e7c6b..e1072809fe31 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -2098,7 +2098,7 @@ static struct platform_driver ipmi_driver = {
> .id_table = ssif_plat_ids
> };
>
> -static int init_ipmi_ssif(void)
> +static int __init init_ipmi_ssif(void)
> {
> int i;
> int rv;
> @@ -2140,7 +2140,7 @@ static int init_ipmi_ssif(void)
> }
> module_init(init_ipmi_ssif);
>
> -static void cleanup_ipmi_ssif(void)
> +static void __exit cleanup_ipmi_ssif(void)
> {
> if (!initialized)
> return;
> diff --git a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c b/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c
> index 486834a962c3..cf670e891966 100644
> --- a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c
> +++ b/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c
> @@ -548,7 +548,7 @@ static struct kcs_bmc_driver kcs_bmc_ipmi_driver = {
> .ops = &kcs_bmc_ipmi_driver_ops,
> };
>
> -static int kcs_bmc_ipmi_init(void)
> +static int __init kcs_bmc_ipmi_init(void)
> {
> kcs_bmc_register_driver(&kcs_bmc_ipmi_driver);
>
> @@ -556,7 +556,7 @@ static int kcs_bmc_ipmi_init(void)
> }
> module_init(kcs_bmc_ipmi_init);
>
> -static void kcs_bmc_ipmi_exit(void)
> +static void __exit kcs_bmc_ipmi_exit(void)
> {
> kcs_bmc_unregister_driver(&kcs_bmc_ipmi_driver);
> }
> diff --git a/drivers/char/ipmi/kcs_bmc_serio.c b/drivers/char/ipmi/kcs_bmc_serio.c
> index 7e2067628a6c..1793358be782 100644
> --- a/drivers/char/ipmi/kcs_bmc_serio.c
> +++ b/drivers/char/ipmi/kcs_bmc_serio.c
> @@ -140,7 +140,7 @@ static struct kcs_bmc_driver kcs_bmc_serio_driver = {
> .ops = &kcs_bmc_serio_driver_ops,
> };
>
> -static int kcs_bmc_serio_init(void)
> +static int __init kcs_bmc_serio_init(void)
> {
> kcs_bmc_register_driver(&kcs_bmc_serio_driver);
>
> @@ -148,7 +148,7 @@ static int kcs_bmc_serio_init(void)
> }
> module_init(kcs_bmc_serio_init);
>
> -static void kcs_bmc_serio_exit(void)
> +static void __exit kcs_bmc_serio_exit(void)
> {
> kcs_bmc_unregister_driver(&kcs_bmc_serio_driver);
> }
> --
> 2.17.1
>
prev parent reply other threads:[~2022-09-22 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 11:19 [PATCH] ipmi: Add __init/__exit annotations to module init/exit funcs Xiu Jianfeng
2022-09-22 15:56 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyyFphRSkO4roYlk@minyard.net \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox