Re: [PATCH v5 6/6] iommu: Propagate return value in ->attach_dev callback functions

Jason Gunthorpe
2022-09-22T17:51:31Z

On Thu, Sep 22, 2022 at 01:54:45AM -0700, Nicolin Chen wrote:
> The mtk_iommu and virtio drivers have places in the ->attach_dev callback
> functions that return hardcode errnos instead of the returned values, but
> callers of these ->attach_dv callback functions may care. Propagate them
> directly without the extra conversions.
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> drivers/iommu/mtk_iommu.c | 2 +-
> drivers/iommu/virtio-iommu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason