From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
jic23@kernel.org, lars@metafoo.de, chiaen_wu@richtek.com,
alice_chen@richtek.com, cy_huang@richtek.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, szunichen@gmail.com
Subject: Re: [PATCH v13 5/5] leds: flash: mt6370: Add MediaTek MT6370 flashlight support
Date: Fri, 7 Oct 2022 12:19:18 +0300 [thread overview]
Message-ID: <Yz/vFml0mwaF0+f9@smile.fi.intel.com> (raw)
In-Reply-To: <CABtFH5J2r=Qq1kNb=yp6Hf7=oKJH9qeiwsO+4ejy5m9N+ZODXg@mail.gmail.com>
On Fri, Oct 07, 2022 at 09:28:17AM +0800, ChiaEn Wu wrote:
> On Wed, Oct 5, 2022 at 8:15 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > > +config LEDS_MT6370_FLASH
> > > + tristate "Flash LED Support for MediaTek MT6370 PMIC"
> >
> > > + depends on LEDS_CLASS && OF
> >
> > Why do you have OF dependency?
> >
>
> Hi Andy,
> The original idea is to use the "fwnode_property_*" related function.
> But this side may only consider just "Build Pass" (?)
Yes, you increase a compile test coverage by dropping that dependency.
> I will remove "OF" in the v14 patch.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-10-07 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 11:43 [PATCH v13 0/5] Add MediaTek MT6370 PMIC support ChiaEn Wu
2022-10-05 11:43 ` [PATCH v13 1/5] dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator ChiaEn Wu
2022-10-05 13:08 ` Rob Herring
2022-10-05 11:43 ` [PATCH v13 2/5] dt-bindings: leds: Add MediaTek MT6370 flashlight ChiaEn Wu
2022-10-05 11:43 ` [PATCH v13 3/5] iio: adc: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-10-05 11:43 ` [PATCH v13 4/5] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-10-05 11:43 ` [PATCH v13 5/5] leds: flash: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
2022-10-05 12:15 ` Andy Shevchenko
2022-10-07 1:28 ` ChiaEn Wu
2022-10-07 9:19 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz/vFml0mwaF0+f9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alice_chen@richtek.com \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox