mainline build failure due to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")

mainline build failure due to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")

[Sudip Mukherjee (Codethink)]

Hi All,

The latest mainline kernel branch fails to build alpha allmodconfig
with the error:

drivers/base/regmap/regmap-mmio.c: In function 'regmap_mmio_noinc_write':
drivers/base/regmap/regmap-mmio.c:222:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration]
  222 |                 writesb(ctx->regs + reg, (const u8 *)val, val_count);
      |                 ^~~~~~~
      |                 writeb
drivers/base/regmap/regmap-mmio.c:225:17: error: implicit declaration of function 'writesw'; did you mean 'writew'? [-Werror=implicit-function-declaration]
  225 |                 writesw(ctx->regs + reg, (const u16 *)val, val_count);
      |                 ^~~~~~~
      |                 writew
drivers/base/regmap/regmap-mmio.c:228:17: error: implicit declaration of function 'writesl'; did you mean 'writel'? [-Werror=implicit-function-declaration]
  228 |                 writesl(ctx->regs + reg, (const u32 *)val, val_count);
      |                 ^~~~~~~
      |                 writel
drivers/base/regmap/regmap-mmio.c:232:17: error: implicit declaration of function 'writesq'; did you mean 'writeq'? [-Werror=implicit-function-declaration]
  232 |                 writesq(ctx->regs + reg, (const u64 *)val, val_count);
      |                 ^~~~~~~
      |                 writeq
drivers/base/regmap/regmap-mmio.c: In function 'regmap_mmio_noinc_read':
drivers/base/regmap/regmap-mmio.c:358:17: error: implicit declaration of function 'readsb'; did you mean 'readb'? [-Werror=implicit-function-declaration]
  358 |                 readsb(ctx->regs + reg, (u8 *)val, val_count);
      |                 ^~~~~~
      |                 readb
drivers/base/regmap/regmap-mmio.c:361:17: error: implicit declaration of function 'readsw'; did you mean 'readw'? [-Werror=implicit-function-declaration]
  361 |                 readsw(ctx->regs + reg, (u16 *)val, val_count);
      |                 ^~~~~~
      |                 readw
drivers/base/regmap/regmap-mmio.c:364:17: error: implicit declaration of function 'readsl'; did you mean 'readl'? [-Werror=implicit-function-declaration]
  364 |                 readsl(ctx->regs + reg, (u32 *)val, val_count);
      |                 ^~~~~~
      |                 readl
drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readq'? [-Werror=implicit-function-declaration]
  368 |                 readsq(ctx->regs + reg, (u64 *)val, val_count);
      |                 ^~~~~~
      |                 readq


git bisect pointed to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")

I will be happy to test any patch or provide any extra log if needed.

Note:
Already reported for next-20220818 at https://lore.kernel.org/lkml/Yv4hhoTTcRuk%2F2Kl@debian/

-- 
Regards
Sudip

Re: mainline build failure due to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

On Wed, Oct 05, 2022 at 07:30:56AM +0100, Sudip Mukherjee (Codethink) wrote:
> Hi All,
> 
> The latest mainline kernel branch fails to build alpha allmodconfig
> with the error:
> 
> drivers/base/regmap/regmap-mmio.c: In function 'regmap_mmio_noinc_write':
> drivers/base/regmap/regmap-mmio.c:222:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration]
>   222 |                 writesb(ctx->regs + reg, (const u8 *)val, val_count);
>       |                 ^~~~~~~
>       |                 writeb

I'd forgotten about this one, sorry, and alpha isn't covered by things
like KernelCI so I didn't see the failure when I checked before sending
my pull request.  It's fixed in -next by 7e772dad9913992 ("alpha: Use
generic <asm-generic/io.h>") from Linus Walleij which is in the
asm-generic tree.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: mainline build failure due to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")

[Linus Walleij]

On Wed, Oct 5, 2022 at 12:39 PM Mark Brown <broonie@kernel.org> wrote:
> On Wed, Oct 05, 2022 at 07:30:56AM +0100, Sudip Mukherjee (Codethink) wrote:
> > Hi All,
> >
> > The latest mainline kernel branch fails to build alpha allmodconfig
> > with the error:
> >
> > drivers/base/regmap/regmap-mmio.c: In function 'regmap_mmio_noinc_write':
> > drivers/base/regmap/regmap-mmio.c:222:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration]
> >   222 |                 writesb(ctx->regs + reg, (const u8 *)val, val_count);
> >       |                 ^~~~~~~
> >       |                 writeb
>
> I'd forgotten about this one, sorry, and alpha isn't covered by things
> like KernelCI so I didn't see the failure when I checked before sending
> my pull request.  It's fixed in -next by 7e772dad9913992 ("alpha: Use
> generic <asm-generic/io.h>") from Linus Walleij which is in the
> asm-generic tree.

There were some further issues with the fix (alpha is really hairy)
but Arnd stepped in and fixed those too, it should all be fixed up when
the arch tree gets pulled.

This was the first time I had to do generic arch maintenance duty so
it was a bit bumpy.

Yours,
Linus Walleij

Re: mainline build failure due to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")

[Linus Torvalds]

On Wed, Oct 5, 2022 at 1:04 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> There were some further issues with the fix (alpha is really hairy)
> but Arnd stepped in and fixed those too, it should all be fixed up when
> the arch tree gets pulled.

That is now pulled and pushed out.

Sudip, can you confirm that the alpha build is ok now?

                  Linus

Re: mainline build failure due to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")

[Sudip Mukherjee]

On Thu, Oct 6, 2022 at 8:13 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Wed, Oct 5, 2022 at 1:04 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > There were some further issues with the fix (alpha is really hairy)
> > but Arnd stepped in and fixed those too, it should all be fixed up when
> > the arch tree gets pulled.
>
> That is now pulled and pushed out.
>
> Sudip, can you confirm that the alpha build is ok now?

Yes, alpha builds with gcc-12 now.
For gcc-11, I had to revert 5d8c3e836fc2 ("drm/amd/display: fix
array-bounds error in dc_stream_remove_writeback()") and it built fine
after that.


-- 
Regards
Sudip