From: Wolfram Sang <wsa@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] i2c: microchip: pci1xxxx: Fix comparison of -EPERM against an unsigned variable
Date: Wed, 5 Oct 2022 20:53:23 +0200 [thread overview]
Message-ID: <Yz3So27pgqX92viW@shikoro> (raw)
In-Reply-To: <20221004192715.173210-1-colin.i.king@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Tue, Oct 04, 2022 at 08:27:15PM +0100, Colin Ian King wrote:
> The comparison of variable ret with -EPERM is always false because
> ret is an u8 type. Fix this by making ret an int.
>
> Cleans up clang warning:
> drivers/i2c/busses/i2c-mchp-pci1xxxx.c:714:10: warning: result of comparison
> of constant -1 with expression of type 'u8' (aka 'unsigned char') is always
> false [-Wtautological-constant-out-of-range-compare]
>
> Fixes: 361693697249 ("i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-10-05 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 19:27 [PATCH][next] i2c: microchip: pci1xxxx: Fix comparison of -EPERM against an unsigned variable Colin Ian King
2022-10-05 18:53 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz3So27pgqX92viW@shikoro \
--to=wsa@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tharunkumar.pasumarthi@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox