From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: carsten.haitzler@foss.arm.com
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
suzuki.poulose@arm.com, mathieu.poirier@linaro.org,
mike.leach@linaro.org, leo.yan@linaro.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v9 02/13] perf test: Add build infra for perf test tools for CoreSight tests
Date: Thu, 6 Oct 2022 08:45:18 -0300 [thread overview]
Message-ID: <Yz6/zlchVnNsVlzJ@kernel.org> (raw)
In-Reply-To: <Yz67SHpIN5NggKEk@kernel.org>
Em Thu, Oct 06, 2022 at 08:26:00AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 09, 2022 at 04:27:52PM +0100, carsten.haitzler@foss.arm.com escreveu:
> > +all: shell_compatibility_test $(ALL_PROGRAMS) $(LANG_BINDINGS) $(OTHER_PROGRAMS) tests-coresight-targets
> >
> > # Create python binding output directory if not already present
> > _dummy := $(shell [ -d '$(OUTPUT)python' ] || mkdir -p '$(OUTPUT)python')
> > @@ -1007,6 +1015,9 @@ install-tests: all install-gtk
> > $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'; \
> > $(INSTALL) tests/shell/lib/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'; \
> > $(INSTALL) tests/shell/lib/*.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'
> > + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/coresight'; \
> > + $(INSTALL) tests/shell/coresight/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/coresight'
> > + $(Q)$(MAKE) -C tests/shell/coresight install-tests
>
> Added a missing ;\ on the line installing the *.py and adjusted use -m
> 644 for the .sh files to follow what was done in:
>
> 0a9eaf616f29ca32 ("perf tools: Don't install data files with x permissions")
>
> @@ -1006,7 +1014,10 @@ install-tests: all install-gtk
> $(INSTALL) tests/shell/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell'; \
> $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'; \
> $(INSTALL) tests/shell/lib/*.sh -m 644 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'; \
> - $(INSTALL) tests/shell/lib/*.py -m 644 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'
> + $(INSTALL) tests/shell/lib/*.py -m 644 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/lib'; \
> + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/coresight'; \
> + $(INSTALL) tests/shell/coresight/*.sh -m 644 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/coresight'
> + $(Q)$(MAKE) -C tests/shell/coresight install-tests
>
Also had to remove:
$(INSTALL) tests/shell/coresight/*.sh -m 644 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/coresight'
from this patch, as it makes install fail at this point in the patchset:
DESCEND plugins
GEN /tmp/build/perf/python/perf.so
INSTALL trace_plugins
INSTALL binaries
INSTALL tests
install: cannot stat 'tests/shell/coresight/*.sh': No such file or directory
make[2]: *** [Makefile.perf:1007: install-tests] Error 1
make[2]: *** Waiting for unfinished jobs....
I'll add it back when the first .sh gets added to tests/shell/coresight/
- Arnaldo
next prev parent reply other threads:[~2022-10-06 11:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 15:27 [PATCH v9 00/13] perf: test: Add trace data quality tests for CoreSight carsten.haitzler
2022-09-09 15:27 ` [PATCH v9 01/13] perf test: Add CoreSight shell lib shared code for future tests carsten.haitzler
2022-09-09 15:27 ` [PATCH v9 02/13] perf test: Add build infra for perf test tools for CoreSight tests carsten.haitzler
2022-10-06 11:26 ` Arnaldo Carvalho de Melo
2022-10-06 11:45 ` Arnaldo Carvalho de Melo [this message]
2022-10-06 12:58 ` Leo Yan
2022-10-06 14:22 ` Arnaldo Carvalho de Melo
2022-10-06 15:07 ` Leo Yan
2022-10-06 17:12 ` Arnaldo Carvalho de Melo
2022-10-06 17:42 ` Arnaldo Carvalho de Melo
2022-10-07 6:28 ` Jiri Slaby
2022-10-07 11:34 ` Carsten Haitzler
2022-10-07 12:44 ` Arnaldo Carvalho de Melo
2022-10-10 7:02 ` Carsten Haitzler
2022-10-10 13:54 ` Arnaldo Carvalho de Melo
2022-10-19 8:11 ` Carsten Haitzler
2022-10-19 8:51 ` Leo Yan
2022-10-19 15:16 ` Arnaldo Carvalho de Melo
2022-09-09 15:27 ` [PATCH v9 03/13] perf test: Add asm pureloop test tool carsten.haitzler
2022-09-09 15:27 ` [PATCH v9 04/13] perf test: Add asm pureloop test shell script carsten.haitzler
2022-09-09 15:27 ` [PATCH v9 05/13] perf test: Add git ignore for perf data generated by the CoreSight tests carsten.haitzler
2022-09-09 15:27 ` [PATCH v9 06/13] perf test: Add memcpy thread test tool carsten.haitzler
2022-09-09 15:27 ` [PATCH v9 07/13] perf test: Add memcpy thread test shell script carsten.haitzler
2022-09-09 15:27 ` [PATCH v9 08/13] perf test: Add thread loop test tool carsten.haitzler
2022-09-09 15:27 ` [PATCH v9 09/13] perf test: Add thread loop test shell scripts carsten.haitzler
2022-09-09 15:28 ` [PATCH v9 10/13] perf test: Add unroll thread test tool carsten.haitzler
2022-09-09 15:28 ` [PATCH v9 11/13] perf test: Add unroll thread test shell script carsten.haitzler
2022-09-09 15:28 ` [PATCH v9 12/13] perf test: Add git ignore for tmp and output files of CoreSight tests carsten.haitzler
2022-09-09 15:28 ` [PATCH v9 13/13] perf test: Add relevant documentation about CoreSight testing carsten.haitzler
2022-10-11 7:27 ` Sven Schnelle
2022-10-19 8:16 ` Carsten Haitzler
2022-10-19 8:43 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz6/zlchVnNsVlzJ@kernel.org \
--to=acme@kernel.org \
--cc=carsten.haitzler@foss.arm.com \
--cc=coresight@lists.linaro.org \
--cc=jirislaby@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox