From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Update comment about config space
Date: Thu, 6 Oct 2022 14:31:44 +0200 [thread overview]
Message-ID: <Yz7KsHGyctceNf+T@lpieralisi> (raw)
In-Reply-To: <20221005194336.gdnu4vfzkudedjw5@pali>
On Wed, Oct 05, 2022 at 09:43:36PM +0200, Pali Rohár wrote:
[...]
> > On
> > the other hand there's really no use in keeping this comment around
> > after that other patch because the documentation for the new macro lays
> > out the details already.
> >
> > Thierry
>
> Ok, whether documentation is needed or not - it is your maintainer
> decision. Maybe really obvious things do not have to be documented.
> Also another look at this problem can be that if somebody wrote wrong
> documentation for it, maybe it is not too obvious? I do not have opinion
> on this, so choose what is better :-)
>
> In any case, wrong documentation (which is the current state) should be
> fixed (and removal in most case is also proper fix).
I agree. I would apply this patch if Thierry is still OK with it.
Lorenzo
next prev parent reply other threads:[~2022-10-06 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 11:32 [PATCH] PCI: tegra: Update comment about config space Pali Rohár
2022-09-28 14:38 ` Thierry Reding
2022-10-05 19:43 ` Pali Rohár
2022-10-06 12:31 ` Lorenzo Pieralisi [this message]
2022-10-06 12:50 ` Thierry Reding
2022-11-01 23:29 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz7KsHGyctceNf+T@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox