From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C76BC433FE for ; Thu, 6 Oct 2022 18:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230320AbiJFSkp (ORCPT ); Thu, 6 Oct 2022 14:40:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiJFSkj (ORCPT ); Thu, 6 Oct 2022 14:40:39 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E9B758B7C for ; Thu, 6 Oct 2022 11:40:38 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id h13so1413071pfr.7 for ; Thu, 06 Oct 2022 11:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OwuwNCcudFZKvWIMInGdJ6VUhKf8xEQfCNCnX/nvy00=; b=dNPxFTIsfmFippclL6a+agEmeFPYHmDbHzLqSpwdwBENXUwEm5bw0G7eh6zqSKEt7I pgKMLnHcLZhDaANzAuCBQisU+WatxB1vZBsVRSqlV/VXLdaCZh1yxwIvwdAP76z+apPB 1sutKYzMneuT8OOJpp46D7lh+WdugURAKQeqMvC3PR4ypIJzP+JLKIvNCeoSUZk6epgi b9z/sIoUZCLk0vFSaWCTzV7Pfco31lSvX22wCGziDVDEQV/COMdDj9g0RoxTi/9RoGuz Rz9Q3s05hUnJNMeQj3sYZzdrPpXkrdDe/lef0EZLvCWA2HodQ87LCqnvjM8OxkbwbCE3 j03A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OwuwNCcudFZKvWIMInGdJ6VUhKf8xEQfCNCnX/nvy00=; b=5WVc6pF/wxob9iE+CnQ3hQ4nuJfgUbbIDUm7lkM0hBnMmgedh1Uo/oYcscNB0sSyCG il+ol5MmNDEv4hhkGwb7hIwX3Ngasgg5+IY470w2sYTtxKd0i3mgyD9/UiGCUReKH9VP /CC5fqxURKy9fNDkX6HUnVhIiEGwWjE5BZ3C+InKilVhn0ax091xxdQs3ZhX73Dh6J/j Lb4yxmjHY0CIuHaXksvfnWxQEq3LIVAlx8YpCS3vCfHefd4santuVmudUD0Ixlv1FrnJ 5TZzaxYEcwOXKkJWNwfHyVsOqpZkfpm/bDmheWA2o0pi+JpSj7Jmz68WOQGAnDiKmFZd 8e8A== X-Gm-Message-State: ACrzQf3B70iHP89IADG79XFiG+wwOeSBDkNE2kyHOBYetHnFvxpaRDfv q7Zg9q/dR4dwpzfUHtiGi0Nr9Q== X-Google-Smtp-Source: AMsMyM4kBYYreOzTG1ll/1RbIjyqSM+SKO0yQvI1LfhKDALqAIEy+Rp5eXhfbc6lLUNt4daatwmhnw== X-Received: by 2002:a63:fd41:0:b0:438:7670:589a with SMTP id m1-20020a63fd41000000b004387670589amr1037333pgj.148.1665081637959; Thu, 06 Oct 2022 11:40:37 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id w11-20020a170902e88b00b00176b3d7db49sm1718233plg.0.2022.10.06.11.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 11:40:37 -0700 (PDT) Date: Thu, 6 Oct 2022 18:40:33 +0000 From: Sean Christopherson To: Santosh Shukla Cc: Paolo Bonzini , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mlevitsk@redhat.com, mail@maciej.szmigiero.name Subject: Re: [PATCHv4 0/8] Virtual NMI feature Message-ID: References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2022, Santosh Shukla wrote: > If NMI virtualization enabled and NMI_INTERCEPT bit is unset > then HW will exit with #INVALID exit reason. > > To enable the VNMI capability, Hypervisor need to program > V_NMI_ENABLE bit 1. > > The presence of this feature is indicated via the CPUID function > 0x8000000A_EDX[25]. Until there is publicly available documentation, I am not going to review this any further. This goes for all new features, e.g. PerfMonv2[*]. I understand the need and desire to get code merged far in advance of hardware being available, but y'all clearly have specs, i.e. this is a very solvable problem. Throw all the disclaimers you want on the specs to make it abundantly clear that they are for preview purposes or whatever, but reviewing KVM code without a spec just doesn't work for me. [*] https://lore.kernel.org/all/20220919093453.71737-1-likexu@tencent.com