Re: [PATCH v2 12/39] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW

Edgecombe, Rick P
2022-10-03T22:29:06Z

On Mon, 2022-10-03 at 11:11 -0700, Nadav Amit wrote:
> Did you have a look at ptep_set_access_flags() and friends and
> checked they
> do not need to be changed too?

ptep_set_access_flags() doesn't actually set any additional dirty bits
on x86, so I think it's ok.

> Perhaps you should at least add some
> assertion just to ensure nothing breaks.

You mean in ptep_set_access_flags()? I think some assertions would be
really great, I'm just not sure where.