From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v2 2/9] pwm: lpss: Move exported symbols to PWM_LPSS namespace
Date: Mon, 26 Sep 2022 13:10:10 +0300 [thread overview]
Message-ID: <YzF6ggfpyZSMfkIN@smile.fi.intel.com> (raw)
In-Reply-To: <20220926095547.be5bbtyqqlm4ytgy@pengutronix.de>
On Mon, Sep 26, 2022 at 11:55:47AM +0200, Uwe Kleine-König wrote:
> On Mon, Sep 26, 2022 at 12:43:47PM +0300, Andy Shevchenko wrote:
> > On Sat, Sep 24, 2022 at 11:59:45AM +0200, Uwe Kleine-König wrote:
> > > On Thu, Sep 08, 2022 at 04:56:51PM +0300, Andy Shevchenko wrote:
...
> > > > +MODULE_IMPORT_NS(PWM_LPSS);
> > >
> > > Each user of the lpss.h header needs that, right? Then the
> > > MODULE_IMPORT_NS statement can go into the header, too.
> >
> > With the same answer as for v1: any user that might include the header for
> > the sake of data types will get the NS inclusion even if they don't need
> > that (yes, I don't think it's practical, but slightly better to make sure
>
> I'm not sure I understand you correctly here. For some headers you
> cannot assume that a file including the header also needs the namespace
> macro, but for pwm-lpss.h that should be a safe assumption.
Yes, it's a safe assumption for _this_ case (as I pointed out above that
there is probably no practical to assume otherwise), in general it may be
not the case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-26 10:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 13:56 [PATCH v2 0/9] pwm: lpss: Clean up and convert to a pure library Andy Shevchenko
2022-09-08 13:56 ` [PATCH v2 1/9] pwm: lpss: Deduplicate board info data structures Andy Shevchenko
2022-09-08 13:56 ` [PATCH v2 2/9] pwm: lpss: Move exported symbols to PWM_LPSS namespace Andy Shevchenko
2022-09-24 9:59 ` Uwe Kleine-König
2022-09-26 9:43 ` Andy Shevchenko
2022-09-26 9:55 ` Uwe Kleine-König
2022-09-26 10:10 ` Andy Shevchenko [this message]
2022-09-08 13:56 ` [PATCH v2 3/9] pwm: lpss: Move resource mapping to the glue drivers Andy Shevchenko
2022-09-24 10:01 ` Uwe Kleine-König
2022-09-08 13:56 ` [PATCH v2 4/9] pwm: lpss: Include headers we are direct user of Andy Shevchenko
2022-09-24 10:04 ` Uwe Kleine-König
2022-09-26 9:48 ` Andy Shevchenko
2022-09-08 13:56 ` [PATCH v2 5/9] pwm: lpss: Use device_get_match_data to get device data Andy Shevchenko
2022-09-24 10:05 ` Uwe Kleine-König
2022-09-08 13:56 ` [PATCH v2 6/9] pwm: lpss: Use DEFINE_RUNTIME_DEV_PM_OPS() and pm_ptr() macros Andy Shevchenko
2022-09-24 10:07 ` Uwe Kleine-König
2022-09-26 9:51 ` Andy Shevchenko
2022-09-08 13:56 ` [PATCH v2 7/9] pwm: lpss: Make use of bits.h macros for all masks Andy Shevchenko
2022-09-24 10:07 ` Uwe Kleine-König
2022-09-08 13:56 ` [PATCH v2 8/9] pwm: lpss: Add a comment to the bypass field Andy Shevchenko
2022-09-24 10:09 ` Uwe Kleine-König
2022-09-08 13:56 ` [PATCH v2 9/9] pwm: lpss: Allow other drivers to enable PWM LPSS Andy Shevchenko
2022-09-24 10:14 ` Uwe Kleine-König
2022-09-26 9:54 ` Andy Shevchenko
2022-09-23 17:03 ` [PATCH v2 0/9] pwm: lpss: Clean up and convert to a pure library Andy Shevchenko
2022-09-24 7:29 ` Uwe Kleine-König
2022-09-27 14:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzF6ggfpyZSMfkIN@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox