* [PATCH v1 1/1] mfd: twl4030: Add missed linux/device.h header
@ 2022-09-23 17:54 Andy Shevchenko
2022-09-26 7:48 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-09-23 17:54 UTC (permalink / raw)
To: Uwe Kleine-König, linux-omap, linux-kernel
Cc: Tony Lindgren, Lee Jones, Andy Shevchenko
With compile testing on non-OMAP platforms compiler might be not happy:
In function ‘twl4030_sih_setup’:
error: implicit declaration of function ‘dev_err’ [-Werror=implicit-function-declaration]
error: implicit declaration of function ‘dev_info’ [-Werror=implicit-function-declaration]
In function ‘twl4030_init_irq’:
error: invalid use of undefined type ‘struct device’
Add missed header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/twl4030-irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 4f576f0160a9..87496c1cb8bc 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -14,6 +14,7 @@
* by syed khasim <x0khasim@ti.com>
*/
+#include <linux/device.h>
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] mfd: twl4030: Add missed linux/device.h header
2022-09-23 17:54 [PATCH v1 1/1] mfd: twl4030: Add missed linux/device.h header Andy Shevchenko
@ 2022-09-26 7:48 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2022-09-26 7:48 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Uwe Kleine-König, linux-omap, linux-kernel, Tony Lindgren
On Fri, 23 Sep 2022, Andy Shevchenko wrote:
> With compile testing on non-OMAP platforms compiler might be not happy:
>
> In function ‘twl4030_sih_setup’:
> error: implicit declaration of function ‘dev_err’ [-Werror=implicit-function-declaration]
> error: implicit declaration of function ‘dev_info’ [-Werror=implicit-function-declaration]
> In function ‘twl4030_init_irq’:
> error: invalid use of undefined type ‘struct device’
>
> Add missed header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/twl4030-irq.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-26 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-23 17:54 [PATCH v1 1/1] mfd: twl4030: Add missed linux/device.h header Andy Shevchenko
2022-09-26 7:48 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox