From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C558C32771 for ; Mon, 26 Sep 2022 12:15:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239420AbiIZMPE (ORCPT ); Mon, 26 Sep 2022 08:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239369AbiIZMOd (ORCPT ); Mon, 26 Sep 2022 08:14:33 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CBEB86703; Mon, 26 Sep 2022 03:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664189958; x=1695725958; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=u7owsbshEAO1iKwIIF0asyEoQmpmhQVZYEfFvSbbgvA=; b=IhcW78cgPnLXMiuAxpE7Ml2lMOENZuyY/aJv9xE2sKU1ACGFUkhfWTxt 22fbYe0MjmGhuv6SpTYVWN9peZufurmcTtJplKGJoQoV67/poJQXwEPmA RojGJDF/tx9M7srWodqxamdf1N7lLNPVJKOFzmOF7wTRIYCinOYt6je/V 60cDJpUtOTueCc+B328gdvm+37vX8ElzpACX4zT6uQAwLUCr0JVsHfQzh 6kP6E6buYTC0vPsXZtkJvTHytBkQjKbG4fLrQqQW8uQ8HVyDgW25lMXAH BOCTXcIl5gtG6HR26c5xxVCobiXOhh2BOdPw5TnuOV7nzpYsVD1Ci3fXP Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="299719957" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="299719957" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2022 03:57:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="623290877" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="623290877" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 26 Sep 2022 03:57:00 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oclnH-007lcz-0H; Mon, 26 Sep 2022 13:56:59 +0300 Date: Mon, 26 Sep 2022 13:56:58 +0300 From: Andy Shevchenko To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] Input: matrix_keypad - replace header inclusions by forward declarations Message-ID: References: <20220923184632.2157-1-andriy.shevchenko@linux.intel.com> <20220923184632.2157-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 01:56:27PM +0300, Andy Shevchenko wrote: > On Fri, Sep 23, 2022 at 12:03:00PM -0700, Dmitry Torokhov wrote: > > On Fri, Sep 23, 2022 at 09:46:32PM +0300, Andy Shevchenko wrote: > > > When the data structure is only referred by pointer, compiler may not need > > > to see the contents of the data type. Thus, we may replace header inclusions > > > by respective forward declarations. ... > > > +struct device; > > > +struct input_dev; > > > > This results in a ton of compile errors. While I believe this change is > > a good one, we need to fix users of this include first. > > Indeed, sorry for breaking things (I compile-tested with limited drivers > enabled). I will look into LKP reports and will fix the users. Ah, thanks, I see your series for that! -- With Best Regards, Andy Shevchenko