From: Alan Stern <stern@rowland.harvard.edu>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Jens Glathe <jens.glathe@oldschoolsolutions.biz>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller
Date: Mon, 26 Sep 2022 11:18:27 -0400 [thread overview]
Message-ID: <YzHCw2FP+CdDK62Y@rowland.harvard.edu> (raw)
In-Reply-To: <c1857a88-2303-43d7-5539-37afd2401a12@linux.intel.com>
On Mon, Sep 26, 2022 at 02:31:42PM +0300, Mathias Nyman wrote:
> Hi
>
> Thanks for the patch, some small changes still needed:
>
> Include subsystem in subject line, something like
> usb: xhci: Add XHCI_SPURIOUS...
And don't forget to include a revision number inside the []'s on the
Subject line for all revised submissions.
> On 25.9.2022 20.22, Jens Glathe wrote:
> > only if it reports as a V0.96 XHCI controller. Appears to fix the errors
It would be nice if the first sentence (not to mention the later ones)
of the patch description actually was a complete sentence. I realize
that lots of commits don't bother to do this, but IMNSHO they ought to.
> > "xhci_hcd <address>; ERROR Transfer event TRB DMA ptr not part of
> > current TD ep_index 2 comp_code 13" that appear spuriously (or pretty
> > often) when using a r8152 USB3 ethernet adapter with integrated hub.
> >
> > Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> > ---
Likewise, for resubmissions don't forget to include a quick description
here (just below the "---" line) of how the resubmission differs from
the earlier versions.
Alan Stern
next prev parent reply other threads:[~2022-09-26 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 17:22 [PATCH] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller Jens Glathe
2022-09-26 8:37 ` Greg KH
2022-09-26 11:31 ` Mathias Nyman
2022-09-26 12:25 ` Re[2]: " Jens Glathe
2022-09-26 15:18 ` Alan Stern [this message]
[not found] <20220830160035.10333-1-jens.glathe@oldschoolsolutions.biz>
2022-09-22 12:00 ` Greg KH
[not found] <em007c3aa5-02c9-4a51-b789-6973e5f116ef@607fe812.com>
2022-08-30 16:32 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2022-08-30 16:31 Jens Glathe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzHCw2FP+CdDK62Y@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox