From: Jason Gunthorpe <jgg@nvidia.com>
To: Deming Wang <wangdeming@inspur.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: Use filp instead of fd
Date: Mon, 26 Sep 2022 14:07:43 -0300 [thread overview]
Message-ID: <YzHcX2VLh+0n2mAP@nvidia.com> (raw)
In-Reply-To: <20220926065407.2389-1-wangdeming@inspur.com>
On Mon, Sep 26, 2022 at 02:54:07AM -0400, Deming Wang wrote:
> The function of kvm_vfio_group_set_spapr_tce and kvm_vfio_group_del
> use fd indirectly.But,it only be used for fd.file. So,we can directly
> use the struct of file instead.
>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
> virt/kvm/vfio.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
I thought about changing this too when I was looking at
this. fdget/fdput includes a tiny micro-optimization that is legal
here, however I doubt anyone cares about performance on this path.
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2022-09-26 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 6:54 [PATCH] vfio: Use filp instead of fd Deming Wang
2022-09-26 13:23 ` Al Viro
2022-09-26 17:07 ` Jason Gunthorpe [this message]
2022-09-26 19:38 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2022-09-27 1:21 tomorrow Wang (王德明)
2022-09-27 1:37 ` Al Viro
2022-09-27 1:25 tomorrow Wang (王德明)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzHcX2VLh+0n2mAP@nvidia.com \
--to=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=wangdeming@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox