From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0022FC07E9D for ; Mon, 26 Sep 2022 17:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbiIZR5s (ORCPT ); Mon, 26 Sep 2022 13:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230051AbiIZR5M (ORCPT ); Mon, 26 Sep 2022 13:57:12 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C67E01183A for ; Mon, 26 Sep 2022 10:35:15 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id 3so4563084qka.5 for ; Mon, 26 Sep 2022 10:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=R783SiSfCMVqAFTcNVl7sF8YnFXoJd82sBRH4fuwwS8=; b=GvOhqyhao+mcwjXW8UmLL7OlZss0mKztQTnLV9JflFLL4ro1u6w/RfLbOMS6mKRS/D yGdvNqxworwRxlFTmUPcZDMSEcUNMnt8XI5ITgGsIEaflVyzGuEoHkdx+py3FKt2cVLT gDEd0Uko4ScuxyIZlDSR00lLgGHzOs4AUaxmWtB5mJ/+AaRfteAeKleq1VVqCJTE6mAz eV0BIwsQR+DE2f4dnfuVfDJBV8NQtQoHgfaAV/6LNyQ+d7HfAqWiucBi79hROOtQQcGD cpt7XpZvQ305WDQGmNXePSxCTS3+QIneOOrS1mIGJHdPah/lj5Onfdlv5/kc733FjRoc Dc/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=R783SiSfCMVqAFTcNVl7sF8YnFXoJd82sBRH4fuwwS8=; b=oHFF+zti5b6cNfcDR1F+6dLo60WJhwJNi/xY+C3v3p82uCxAXqnUGWAxC7JFqnI6lX aqcBB/WoNGIdxI3Br6uWOozuuICM04a5rTWfngWllFNAak1LCZic7E1ty149Avdo+zMZ nnlFBFtBV9Y9MuV2d1oTOIIjDJ4B7ggcR4MdlR0lHSlKOLmKQ4s++PmS+Z6nhiU5Yh47 L7NLXvHF/iczIPnTbf5jlnAMH9FG+gR2gx8v+kcf1ydo0LkwWaZsZVttcck67iPDpYUq e5V7I3rKKCtMF3zK0YIQ3HHgKlhdaVUXUPBtzkUtShIiXJymFvISpD6DaH7bXYa6mVo3 uLHg== X-Gm-Message-State: ACrzQf1w4irB2UOrZQV9417mPbKjbgiLOsPPgl5SJfhum7Ynn3gVJYCa s40eM9fzJt3ERXHvvPgcI7GDmH4/+jcJ7A== X-Google-Smtp-Source: AMsMyM7ZdCi0AXhel9Eb4di0Rz2+bPGv2Tlf7yDdRWDAk6VAYl5u0Y5iIdglC17r9JMvLiVGkiR5Iw== X-Received: by 2002:a05:620a:1312:b0:6ce:5f1b:b05f with SMTP id o18-20020a05620a131200b006ce5f1bb05fmr14365845qkj.360.1664213714032; Mon, 26 Sep 2022 10:35:14 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id o29-20020a05620a0d5d00b006b60d5a7205sm11064665qkl.51.2022.09.26.10.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 10:35:13 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ocs0e-000BUR-MP; Mon, 26 Sep 2022 14:35:12 -0300 Date: Mon, 26 Sep 2022 14:35:12 -0300 From: Jason Gunthorpe To: ruanjinjie Cc: dennis.dalessandro@cornelisnetworks.com, leon@kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] IB/hfi1,PCI: Fix missing pci_disable_device() in probe and remove Message-ID: References: <20220922024601.3643622-1-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922024601.3643622-1-ruanjinjie@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2022 at 10:46:01AM +0800, ruanjinjie wrote: > Replace pci_enable_device() with pcim_enable_device(), > pci_disable_device() and pci_release_regions() will be > called in release automatically. > > Signed-off-by: ruanjinjie > --- > drivers/infiniband/hw/hfi1/pcie.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Please no, at LPC it seems the general consensus is that the devm varients were a Bad Idea. If the code as-is is correct then lets leave it alone. Jason