From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ard Biesheuvel <ardb@kernel.org>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] random: split initialization into early arch step and later non-arch step
Date: Tue, 27 Sep 2022 11:30:51 +0200 [thread overview]
Message-ID: <YzLCy2rVIBebeMrB@zx2c4.com> (raw)
In-Reply-To: <CAHmME9qTf+aDmBen2dFXPmbDGkn1E4=oXqqeBRiguLCo7K9EhQ@mail.gmail.com>
On Tue, Sep 27, 2022 at 10:34:16AM +0200, Jason A. Donenfeld wrote:
> > > Yes, we could maybe *change* to using init_utsname if we wanted. That
> > > seems kind of different though. So I'd prefer that to be a different
> > > patch, which would require looking at the interaction with early
> > > hostname setting and such. If you want to do that work, I'd certainly
> > > welcome the patch.
> >
> > Er, isn't that _WAY_ later? Like, hostname isn't set until sysctls up
> > and running, etc. I haven't actually verified 100% but it looks like
> > current->utsname is exactly init_utsname currently.
>
> If init_utsname()==utsname() and all is fine, can you please send a
> patch atop random.git adjusting that and explaining why? I would
> happily take such a patch. If your suspicion is correct, it would make
> a most welcome improvement.
https://lore.kernel.org/lkml/20220927092920.1559685-1-Jason@zx2c4.com
prev parent reply other threads:[~2022-09-27 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 16:03 [PATCH] random: split initialization into early arch step and later non-arch step Jason A. Donenfeld
2022-09-26 16:22 ` Andrew Morton
2022-09-26 16:29 ` Jason A. Donenfeld
2022-09-26 18:22 ` Kees Cook
2022-09-26 18:52 ` Jason A. Donenfeld
2022-09-27 3:23 ` Kees Cook
2022-09-27 8:34 ` Jason A. Donenfeld
2022-09-27 9:30 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzLCy2rVIBebeMrB@zx2c4.com \
--to=jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox