From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 935AAC6FA82 for ; Tue, 27 Sep 2022 12:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231282AbiI0MIE (ORCPT ); Tue, 27 Sep 2022 08:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbiI0MIB (ORCPT ); Tue, 27 Sep 2022 08:08:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B07E2A2A9F; Tue, 27 Sep 2022 05:08:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48D7F60EF1; Tue, 27 Sep 2022 12:08:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F11CC433D6; Tue, 27 Sep 2022 12:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664280479; bh=ICu0Mbj7QJ+Q9rgfCJL0ERLgAyF1QTBOrSbazfxcV8k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R8jWz48QdCdkCpBHDo8SrbZyq2yp/aty3qEKLFySWdlBWePxkemalROMgE2XqWky3 t0tv+8tbkuoRIv8LGQbVuz4m7P+NPWp4xj9hFU1ZyFJk+K0+99snDljH7njF+NjZN3 t/2VCIMp6VQWJEyWtsMfhsZkTuTSbCHkM7JrD4VOGvhXTj6pVnC9FIWyeK+JdSWkpd ez3Cg45AfWOgQP3p//NxzRGDs8MN8K3iqmU+kJD6xox07kmOVdr7Cy+bPP0fGAtuPY Qndq+L+XgcyMpDAN4pwr2wRoqtMnDDgRdtguRWdZh8Ld5PNrwXk380yFJCnrc2wfJW XqoSVNiYhjl2Q== Date: Tue, 27 Sep 2022 14:07:52 +0200 From: Lorenzo Pieralisi To: Bjorn Helgaas , gregkh@linuxfoundation.org Cc: cgel.zte@gmail.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot Subject: Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result variable Message-ID: References: <20220906071636.336853-1-ye.xingchen@zte.com.cn> <20220906212520.GA45166@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906212520.GA45166@bhelgaas> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+Greg] On Tue, Sep 06, 2022 at 04:25:20PM -0500, Bjorn Helgaas wrote: > On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@gmail.com wrote: > > From: ye xingchen > > > > Return the value iproc_pcie_setup_ib() directly instead of storing it in > > another redundant variable. > > > > Reported-by: Zeal Robot > > Signed-off-by: ye xingchen > > This patch itself is fine, but was posted by cgel.zte@gmail.com, not by > "ye xingchen ", so it needs another signoff > and full name so the chain is complete. For more details see: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.18#n363 Greg, Bjorn, I believe that appending a SoB like this myself is fine: Signed-off-by: CGEL ZTE It is a SOB already in kernel commit logs - I assume that's the right thing to do in this case, please let me know if it isn't and what should we do instead. Thanks, Lorenzo > Bjorn > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel