From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jilin Yuan <yuanjilin@cdjrlc.com>
Cc: daniel@zonque.org, haojian.zhuang@gmail.com,
robert.jarzmik@free.fr, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.orgc,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: pxa: fix repeated words in comments
Date: Tue, 27 Sep 2022 19:40:18 +0700 [thread overview]
Message-ID: <YzLvMvouCIcXCJlU@debian.me> (raw)
In-Reply-To: <20220914083746.29370-1-yuanjilin@cdjrlc.com>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Wed, Sep 14, 2022 at 04:37:46PM +0800, Jilin Yuan wrote:
> -/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */
> +/* The actual GPIO offsets get filled in the palm27x_udc_init() call */
> static struct gpiod_lookup_table palm27x_udc_gpiod_table = {
> .dev_id = "gpio-vbus",
> .table = {
NAK!
The reasons:
* I read the comment above (without the patch) as "The actual offsets get
set in the function call". Both ins are of different parts of speech
(adverbial and preposition).
* As I stated to other developers (see [1] and [2]), you and other
@cdjrlc.com developers ignore critical code reviews (no reply to
them).
Thanks.
[1]: https://lore.kernel.org/lkml/ca8efe3b-1aeb-8a4e-79e9-3f3f9281ff34@gmail.com/
[2]: https://lore.kernel.org/lkml/YzJaIolrTarQ4Qdn@debian.me/
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-09-27 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 8:37 [PATCH] ARM: pxa: fix repeated words in comments Jilin Yuan
2022-09-27 12:40 ` Bagas Sanjaya [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-14 8:40 Jilin Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzLvMvouCIcXCJlU@debian.me \
--to=bagasdotme@gmail.com \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.orgc \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox