Re: [RFC PATCH 17/23] thermal: intel: hfi: Enable the Intel Thread Director

Peter Zijlstra
2022-09-27T12:01:17Z

On Fri, Sep 09, 2022 at 04:11:59PM -0700, Ricardo Neri wrote:

> +config INTEL_THREAD_DIRECTOR
> + bool "Intel Thread Director"
> + depends on INTEL_HFI_THERMAL
> + depends on SMP
> + select SCHED_TASK_CLASSES
> + help
> + Select this option to enable the Intel Thread Director. If selected,
> + hardware classifies tasks based on the type of instructions they
> + execute. It also provides performance capabilities for each class of
> + task. On hybrid processors, the scheduler uses this data to place
> + tasks of classes of higher performance on higher-performnance CPUs.

Do we really need yet another CONFIG symbol for all this!? AFAICT this
Thread Director crud simply extends the HFI table and doesn't actually
carry that much code with it.

Best to always have it on when HFI is on, no?