From: Carlos Llamas <cmllamas@google.com>
To: Zhang Qiao <zhangqiao22@huawei.com>
Cc: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, joel@joelfernandes.org, brauner@kernel.org,
surenb@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] android: binder: Remove comments about tsk fields
Date: Tue, 27 Sep 2022 17:39:14 +0000 [thread overview]
Message-ID: <YzM1QkafOVNuNLkp@google.com> (raw)
In-Reply-To: <20220928004610.58756-1-zhangqiao22@huawei.com>
On Wed, Sep 28, 2022 at 08:46:10AM +0800, Zhang Qiao wrote:
> Commit a0c2baaf81bd ("android: binder: Don't get mm
> from task") remove the binder_alloc struct's tsk, but
> didn't remove the header commment about '@tsk'.
> So this patch remove it.
>
> Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
> ---
> drivers/android/binder_alloc.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/android/binder_alloc.h b/drivers/android/binder_alloc.h
> index 1e4fd37af5e0..fe0738fb9c8c 100644
> --- a/drivers/android/binder_alloc.h
> +++ b/drivers/android/binder_alloc.h
> @@ -76,8 +76,6 @@ struct binder_lru_page {
> * struct binder_alloc - per-binder proc state for binder allocator
> * @vma: vm_area_struct passed to mmap_handler
> * (invarient after mmap)
> - * @tsk: tid for task that called init for this proc
> - * (invariant after init)
> * @vma_vm_mm: copy of vma->vm_mm (invarient after mmap)
> * @buffer: base of per-proc address space mapped via mmap
> * @buffers: list of all buffers for this proc
> --
> 2.17.1
>
Thanks but this has already been addressed here:
https://git.kernel.org/next/linux-next/c/7b0dbd940765
--
Carlos Llamas
prev parent reply other threads:[~2022-09-27 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 0:46 [PATCH -next] android: binder: Remove comments about tsk fields Zhang Qiao
2022-09-27 17:39 ` Carlos Llamas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzM1QkafOVNuNLkp@google.com \
--to=cmllamas@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox