public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Jens Hillenstedt <jens.hillenstedt@ise.de>
Cc: support.opensource@diasemi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.
Date: Wed, 28 Sep 2022 11:38:47 +0100	[thread overview]
Message-ID: <YzQkNy3D1vcqOH8B@google.com> (raw)
In-Reply-To: <20220915092004.168744-1-jens.hillenstedt@ise.de>

On Thu, 15 Sep 2022, Jens Hillenstedt wrote:

> In da9062_i2c_probe() regmap_clear_bits() tries to access CONFIG_J
> register. As CONFIG_J is not present in da9061_aa_writeable_ranges[] probe
> of da9061 fails:
> 
>   da9062 2-0058: Entering I2C mode!
>   da9062 2-0058: Failed to set Two-Wire Bus Mode.
>   da9062: probe of 2-0058 failed with error -5
> 
> Add CONFIG_J register to da9061_aa_writeable_ranges[].
> 
> Fixes: 5c6f0f456351 ("mfd: da9062: Support SMBus and I2C mode")
> Signed-off-by: Jens Hillenstedt <jens.hillenstedt@ise.de>
> ---
>  drivers/mfd/da9062-core.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]

      parent reply	other threads:[~2022-09-28 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15  9:20 [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode Jens Hillenstedt
2022-09-15 14:23 ` DLG Adam Ward
2022-09-28 10:38 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzQkNy3D1vcqOH8B@google.com \
    --to=lee@kernel.org \
    --cc=jens.hillenstedt@ise.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=support.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox