Re: [PATCH v1 1/1] pwm: core: Replace custom implementation of device_match_fwnode()

Andy Shevchenko
2022-09-28T15:40:32Z

On Wed, Sep 28, 2022 at 04:57:57PM +0200, Thierry Reding wrote:
> On Wed, Sep 28, 2022 at 05:49:36PM +0300, Andy Shevchenko wrote:
> > On Wed, Sep 28, 2022 at 04:26:47PM +0200, Thierry Reding wrote:
> > > On Tue, Sep 27, 2022 at 08:22:58PM +0300, Andy Shevchenko wrote:
> > > > Replace custom implementation of the device_match_fwnode().
> >
> > > I really don't see the point in having an exported symbol for this. It's
> > > a simple comparison and the result is even longer than the original.
> >
> > Longer doesn't always mean worse.
> >
> > > The
> > > *only* reason why this helper exists seems to be because it is getting
> > > used in *_find_device() callbacks.
> >
> > Yes and no. Initially for the purpose to be a callback it can be reused.
> > The point is that it hides the dev_fwnode() machinery behind and taking
> > into account ongoing discussion about constification of the dev_fwnode()
> > we might need to touch this or similar places to avoid problems with
> > compiler.
>
> Maybe next time use that argument in the commit message. That's much
> more convincing than a useless "replace custom implementation" because
> that just makes it look like you're doing this to pass the time or
> something.

Noted.

> Applied, with a slightly updated commit message, thanks.

Thank you!

--
With Best Regards,
Andy Shevchenko