Re: [PATCH v1 1/1] pwm: core: Replace custom implementation of device_match_fwnode()

Thierry Reding
2022-09-28T14:26:57Z

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

On Tue, Sep 27, 2022 at 08:22:58PM +0300, Andy Shevchenko wrote:
> Replace custom implementation of the device_match_fwnode().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pwm/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I really don't see the point in having an exported symbol for this. It's
a simple comparison and the result is even longer than the original. The
*only* reason why this helper exists seems to be because it is getting
used in *_find_device() callbacks.

Honestly, I don't see a reason why this should be applied. And frankly,
why bother making all these changes. It's a waste of time, in my
opinion.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]