From: Thierry Reding <thierry.reding@gmail.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Update comment about config space
Date: Wed, 28 Sep 2022 16:38:27 +0200 [thread overview]
Message-ID: <YzRcYwQYlawV10QS@orome> (raw)
In-Reply-To: <20220911113216.14892-1-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Sun, Sep 11, 2022 at 01:32:16PM +0200, Pali Rohár wrote:
> Like many other ARM PCIe controllers, it uses old PCI Configuration
> Mechanism #1 from PCI Local Bus for accessing PCI config space.
> It is not PCIe ECAM in any case.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/pci/controller/pci-tegra.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Perhaps this should be rolled into the PCI_CONF1_EXT_ADDRESS patch? On
the other hand there's really no use in keeping this comment around
after that other patch because the documentation for the new macro lays
out the details already.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-28 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 11:32 [PATCH] PCI: tegra: Update comment about config space Pali Rohár
2022-09-28 14:38 ` Thierry Reding [this message]
2022-10-05 19:43 ` Pali Rohár
2022-10-06 12:31 ` Lorenzo Pieralisi
2022-10-06 12:50 ` Thierry Reding
2022-11-01 23:29 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzRcYwQYlawV10QS@orome \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox