From: Thierry Reding <thierry.reding@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/7] pwm: lpss: Make use of bits.h macros for all masks
Date: Wed, 28 Sep 2022 16:49:57 +0200 [thread overview]
Message-ID: <YzRfFVdZ5XsStnFq@orome> (raw)
In-Reply-To: <YzRde5PuFnL5KbrC@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Wed, Sep 28, 2022 at 05:43:07PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 28, 2022 at 04:20:46PM +0200, Thierry Reding wrote:
> > On Tue, Sep 27, 2022 at 07:24:20PM +0300, Andy Shevchenko wrote:
> > > Make use of the GENMASK() (far less error-prone, far more concise).
> >
> > Very subjective.
>
> See an example why not: 0a90ed8d0cfa ("platform/x86: pmc_atom: Fix SLP_TYPx
> bitfield mask").
Hardly comparable to this particular case. And really this is stuff
that's getting on my nerves. People constantly replacing perfectly fine
code with something equivalent just for the sake of it.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-28 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 16:24 [PATCH v4 0/7] pwm: lpss: Clean up and convert to a pure library Andy Shevchenko
2022-09-27 16:24 ` [PATCH v4 1/7] pwm: lpss: Deduplicate board info data structures Andy Shevchenko
2022-09-27 16:24 ` [PATCH v4 2/7] pwm: lpss: Move exported symbols to PWM_LPSS namespace Andy Shevchenko
2022-09-27 16:24 ` [PATCH v4 3/7] pwm: lpss: Move resource mapping to the glue drivers Andy Shevchenko
2022-09-27 16:24 ` [PATCH v4 4/7] pwm: lpss: Use device_get_match_data to get device data Andy Shevchenko
2022-09-27 16:24 ` [PATCH v4 5/7] pwm: lpss: Use DEFINE_RUNTIME_DEV_PM_OPS() and pm_ptr() macros Andy Shevchenko
2022-09-27 16:24 ` [PATCH v4 6/7] pwm: lpss: Make use of bits.h macros for all masks Andy Shevchenko
2022-09-28 14:20 ` Thierry Reding
2022-09-28 14:43 ` Andy Shevchenko
2022-09-28 14:49 ` Thierry Reding [this message]
2022-09-27 16:24 ` [PATCH v4 7/7] pwm: lpss: Add a comment to the bypass field Andy Shevchenko
2022-09-28 14:22 ` [PATCH v4 0/7] pwm: lpss: Clean up and convert to a pure library Thierry Reding
2022-09-28 14:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzRfFVdZ5XsStnFq@orome \
--to=thierry.reding@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox