From: Wolfram Sang <wsa@kernel.org>
To: Weilong Chen <chenweilong@huawei.com>
Cc: yangyicong@hisilicon.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH next v3] i2c: hisi: Add support to get clock frequency from clock property
Date: Wed, 28 Sep 2022 21:52:04 +0200 [thread overview]
Message-ID: <YzSl5Dm15ZDCxf15@shikoro> (raw)
In-Reply-To: <20220926091503.199474-1-chenweilong@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On Mon, Sep 26, 2022 at 05:15:03PM +0800, Weilong Chen wrote:
> Support the driver to obtain clock information by clk_rate or
> clock property. Find clock first, if not, fall back to clk_rate.
This commit message describes what the patch does. But it misses the
explanation why this needs to be done. Could you add this information,
please? Patch itself looks also good to me.
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> Acked-by: Yicong Yang <yangyicong@hisilicon.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-28 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 9:15 [PATCH next v3] i2c: hisi: Add support to get clock frequency from clock property Weilong Chen
2022-09-28 19:52 ` Wolfram Sang [this message]
2022-09-29 6:24 ` chenweilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzSl5Dm15ZDCxf15@shikoro \
--to=wsa@kernel.org \
--cc=chenweilong@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox