From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A68DDC04A95 for ; Wed, 28 Sep 2022 19:52:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233787AbiI1TwP (ORCPT ); Wed, 28 Sep 2022 15:52:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbiI1TwM (ORCPT ); Wed, 28 Sep 2022 15:52:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 846455B046; Wed, 28 Sep 2022 12:52:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1B930B821DA; Wed, 28 Sep 2022 19:52:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2354CC433D6; Wed, 28 Sep 2022 19:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664394728; bh=+OL0HwkPt60vRVtBHGWFCjrgOWI9WW012wo1ahfHcsg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ve4GuaGKgVyYIiDVmqu/n02Q7MouLynC0bMVG+cFQKh6kZ9kk57WBgGv6uw2zWZKY +6YPKDs7Zl2K56CaBD0yJ6elE1xzT/ZyQU63U6yXdGPm1yEGJufPhRejLEWoDQDU08 OFTE+7PNHeydA5vCAz2QIBHiz5McycHCr5xN9Fx31sjbK4oU80y4Etj3cwrjETlN6q 3O+yIgxrSVxf7oJunP+nrruJYCJ0e71saPN1GoH58IAHIm78lPx8IeclEXfNDOVWTg pEh+mQ/8+y9nW21whw0Iw3mWw4yfyxaj2jaCpqnBy16Ob1grn0wVMOUjYL8TPaOmGO 44mPpgNGNkKfA== Date: Wed, 28 Sep 2022 21:52:04 +0200 From: Wolfram Sang To: Weilong Chen Cc: yangyicong@hisilicon.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next v3] i2c: hisi: Add support to get clock frequency from clock property Message-ID: Mail-Followup-To: Wolfram Sang , Weilong Chen , yangyicong@hisilicon.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220926091503.199474-1-chenweilong@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="s/3WXlL7qU/MTWH0" Content-Disposition: inline In-Reply-To: <20220926091503.199474-1-chenweilong@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --s/3WXlL7qU/MTWH0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 26, 2022 at 05:15:03PM +0800, Weilong Chen wrote: > Support the driver to obtain clock information by clk_rate or > clock property. Find clock first, if not, fall back to clk_rate. This commit message describes what the patch does. But it misses the explanation why this needs to be done. Could you add this information, please? Patch itself looks also good to me. >=20 > Signed-off-by: Weilong Chen > Acked-by: Yicong Yang --s/3WXlL7qU/MTWH0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmM0peEACgkQFA3kzBSg KbZ+ORAAnNRdXp01dfBdAQgs8TNVhrNpXV2utaY+dGiGonIjruQi354t6hLr8276 3myO5OIrHChb57/8BJeCUYA95RC/wOwGTOZ3/LnV8fTF2XrFJfdN0/Lr/Y3/taid koOYouyhzHZs6PT7+zTyzpMkwSvChKgDoDqiZdqBmUgcH6XtXJlGteimwsOf7r3K Yj8tcea5WaDSNjDaGNXCuWK/BwMNdwQL1A5jEcQIYrPEmRW8Kf2oc8n7ZPiecs6i DCo/Y6WrSYy1mTqZ99UNtxLpCBVzN4LIiVYE9Dqv2eGv9PoWj298BQYNezR0i74h 7FD6Mlky18nGdBfdfYTo9eNuW1tWFWcwV4f/q3hFi7dUHDu/Mam72qTrnr28/60X 6zvSimfadD38nglNSyeo3jpyhg4DRAUshkY2pMUPVriTsjM7xDyAknWZByawlU2k x2sfWx11BxXECME+Lm2kgqy6TAA54FfkeKVrDJbxg+g2jhkvvZ8XmwY4ogr7L2pP NbQ5ESig5ive6ipddcegPhpt3BX1+HikmV6ApHgyfgJ0s8wqcLEw7r8lkEM4zHxY dYpVc1vz0eupfxEwxD4blT4TXljifpDwxTVWnURi//W436JPkWW7RAFdsRT81Ape yj3F4m+TadrMQ9mGtfBXO9EV0TScWLXJxXbvYzvvyDTuBNU1EJM= =ljii -----END PGP SIGNATURE----- --s/3WXlL7qU/MTWH0--