From: Dominique Martinet <asmadeus@codewreck.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: v9fs-developer@lists.sourceforge.net, linux_oss@crudebyte.com,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH 2/2] 9p: client_create: init fcall_cache earlier
Date: Thu, 29 Sep 2022 16:03:50 +0900 [thread overview]
Message-ID: <YzVDVhSHBVFltc4o@codewreck.org> (raw)
In-Reply-To: <YzUzyw9JE4lFWKo5@unreal>
Leon Romanovsky wrote on Thu, Sep 29, 2022 at 08:57:31AM +0300:
> > + * followed by data accessed from userspace by read
> > + * Note we do not check for failure here because the cache is
> > + * optional; warning will be issued on dmesg for failure.
> > + */
> > + clnt->fcall_cache =
> > + kmem_cache_create_usercopy("9p-fcall-cache", clnt->msize,
> > + 0, 0, P9_HDRSZ + 4,
> > + clnt->msize - (P9_HDRSZ + 4),
> > + NULL);
> > +
>
> clnt->msize can be changed after call to ->create() if it is larger than clnt->trans_mod->maxsize).
Ugh, that's what I get for doing this in a hurry because you're all
talking about order this order that...
This is absolutely correct, I'm dropping this patch.
--
Dominique
next prev parent reply other threads:[~2022-09-29 7:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 11:29 [syzbot] KASAN: use-after-free Read in rdma_close syzbot
2022-09-28 10:07 ` Leon Romanovsky
2022-09-28 10:43 ` asmadeus
2022-09-28 10:49 ` Leon Romanovsky
2022-09-28 11:23 ` asmadeus
2022-09-28 11:54 ` Leon Romanovsky
2022-09-28 12:57 ` Christian Schoenebeck
2022-09-28 21:52 ` asmadeus
2022-09-29 6:10 ` Leon Romanovsky
2022-09-28 21:44 ` [PATCH 1/2] 9p: client_create/destroy: only call trans_mod->close after create Dominique Martinet
2022-09-28 21:44 ` [PATCH 2/2] 9p: client_create: init fcall_cache earlier Dominique Martinet
2022-09-29 5:57 ` Leon Romanovsky
2022-09-29 7:03 ` Dominique Martinet [this message]
2022-09-28 21:58 ` [PATCH 1/2 v2] 9p: client_create/destroy: only call trans_mod->close after create Dominique Martinet
2022-09-28 22:19 ` [PATCH v3] " Dominique Martinet
2022-09-29 5:54 ` Leon Romanovsky
2022-09-29 7:24 ` Dominique Martinet
2022-12-30 10:34 ` [syzbot] KASAN: use-after-free Read in rdma_close syzbot
2023-01-13 10:35 ` syzbot
2023-01-27 10:36 ` syzbot
2023-02-10 10:36 ` syzbot
2023-02-24 10:37 ` syzbot
2023-03-10 10:38 ` syzbot
2023-03-24 10:38 ` syzbot
2023-04-07 10:38 ` syzbot
2023-04-21 10:39 ` syzbot
2023-05-05 10:40 ` syzbot
2023-05-19 10:40 ` syzbot
2023-06-02 10:42 ` syzbot
2023-06-02 10:57 ` Aleksandr Nogikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzVDVhSHBVFltc4o@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox