From: "Theodore Ts'o" <tytso@mit.edu>
To: "Marc Aurèle La France" <tsi@tuyoix.net>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Register ext[23] support only after successful ext4 registration
Date: Thu, 29 Sep 2022 10:20:47 -0400 [thread overview]
Message-ID: <YzWpv8ZKJ7BrOBsg@mit.edu> (raw)
In-Reply-To: <7ef87cdb-0d0b-2488-6f42-a670a6454630@tuyoix.net>
On Wed, Aug 10, 2022 at 02:20:45PM -0600, Marc Aurèle La France wrote:
> Register ext4 as a "replacement" for ext2 and ext3 only after ext4 itself has
> been successfully registered. As a side effect, this allows
> unregister_as_ext[23]() to be inlined.
The corrent ordering is deliberate; it allows file systems that have
ext2 and ext3 only file system features will be reported as using ext2
and ext3 in /proc/mounts. This doesn't matter quite as much, but it
could potentially break userspace if a legacy file system that only
has ext2 file system features is mounted and reported as ext4.
So sorry, I can't take this change.
- Ted
next prev parent reply other threads:[~2022-09-29 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 20:20 [PATCH] ext4: Register ext[23] support only after successful ext4 registration Marc Aurèle La France
2022-09-29 14:20 ` Theodore Ts'o [this message]
2022-09-30 3:45 ` Marc Aurèle La France
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzWpv8ZKJ7BrOBsg@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tsi@tuyoix.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox