From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF30BC433FE for ; Fri, 30 Sep 2022 11:33:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231629AbiI3LdU (ORCPT ); Fri, 30 Sep 2022 07:33:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbiI3Lcz (ORCPT ); Fri, 30 Sep 2022 07:32:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E772D1DA53; Fri, 30 Sep 2022 04:25:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A5DADB82815; Fri, 30 Sep 2022 11:25:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42EFCC433D6; Fri, 30 Sep 2022 11:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664537129; bh=EtTfFT95kJOlidZdVTvfFENPF4UX2MmvkhuMlNo/5/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fxkXsVbJTnaqNg90wrGGaKbu5cDEYBRIK3HdYvLdz8bNGTDmaC+f0PitO10wCHvEQ VCrHYTpLIt/NtBwjyh9Ub8KVU4GCdx8w0RNFyzy3UQUulF8alvQ09EowF2EwF2TX68 Jpql8OVFsie8fCWVhzLnIslIJ+t94sucOJ74pxwUnPafyQXNrDS/8qIkLA6jAOKYiD Fg7CoKcr9IRgbsS9lZayoksFlTI/eTMzjrulnpxN23xm+HFabMH9CDWN1AzaXoqwuH EdTfBibGznid03MlMKY4hl35DM0ykGgni+x5PtKiFfjMvHcPlAfALnUXtsJjnD2Nwu 7p9tEdLcvT4qQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oeE9A-000157-M8; Fri, 30 Sep 2022 13:25:36 +0200 Date: Fri, 30 Sep 2022 13:25:36 +0200 From: Johan Hovold To: Dmitry Baryshkov Cc: Johan Hovold , Vinod Koul , Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/11] phy: qcom-qmp-pcie: drop bogus register update Message-ID: References: <20220929092916.23068-1-johan+linaro@kernel.org> <20220929092916.23068-12-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 30, 2022 at 01:57:46PM +0300, Dmitry Baryshkov wrote: > On 29/09/2022 12:29, Johan Hovold wrote: > > Since commit 0d58280cf1e6 ("phy: Update PHY power control sequence") the > > PHY is powered on before configuring the registers and only the MSM8996 > > PCIe PHY, which includes the POWER_DOWN_CONTROL register in its PCS > > initialisation table, may possibly require a second update afterwards. > > > > To make things worse, the POWER_DOWN_CONTROL register lies at a > > different offset on more recent SoCs so that the second update, which > > still used a hard-coded offset, would write to an unrelated register > > (e.g. a revision-id register on SC8280XP). > > > > As the MSM8996 PCIe PHY is now handled by a separate driver, simply drop > > the bogus register update. > > > > Fixes: e4d8b05ad5f9 ("phy: qcom-qmp: Use proper PWRDOWN offset for sm8150 USB") added support > > Signed-off-by: Johan Hovold > > Reviewed-by: Dmitry Baryshkov > Tested-by: Dmitry Baryshkov #RB3 Thanks for confirming. Johan