From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] printf: Emit "SUCCESS" if NULL is passed for %pe
Date: Fri, 30 Sep 2022 16:41:24 +0300 [thread overview]
Message-ID: <YzbyBA9uJUL/a32P@smile.fi.intel.com> (raw)
In-Reply-To: <20220930111050.1296018-1-u.kleine-koenig@pengutronix.de>
On Fri, Sep 30, 2022 at 01:10:50PM +0200, Uwe Kleine-König wrote:
> For code that emits a string representing a usual return value it's
> convenient to have a 0 result in a string representation of success
> instead of "00000000".
This is a controversial change. For APIs that comes to my mind it means
"OPTIONAL resource NOT FOUND, while no error happened". Doe it mean success?
I don't think so.
> A usecase is tracing where the return value of a callback is emitted,
> see
> https://lore.kernel.org/linux-pwm/20220916151506.298488-2-u.kleine-koenig@pengutronix.de
> for an example.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-30 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 11:10 [PATCH] printf: Emit "SUCCESS" if NULL is passed for %pe Uwe Kleine-König
2022-09-30 12:14 ` Petr Mladek
2022-09-30 13:24 ` Uwe Kleine-König
2022-09-30 13:42 ` Andy Shevchenko
2022-09-30 13:48 ` Uwe Kleine-König
2022-09-30 13:41 ` Andy Shevchenko [this message]
2022-09-30 14:05 ` Uwe Kleine-König
2022-10-03 13:26 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzbyBA9uJUL/a32P@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox