From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF745C433F5 for ; Fri, 30 Sep 2022 18:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232209AbiI3SdJ (ORCPT ); Fri, 30 Sep 2022 14:33:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232268AbiI3Sc6 (ORCPT ); Fri, 30 Sep 2022 14:32:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D31E41B7D95 for ; Fri, 30 Sep 2022 11:32:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 77706623FE for ; Fri, 30 Sep 2022 18:32:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E60BAC433D6; Fri, 30 Sep 2022 18:32:53 +0000 (UTC) Date: Fri, 30 Sep 2022 19:32:50 +0100 From: Catalin Marinas To: Isaac Manjarres Cc: Herbert Xu , Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Saravana Kannan , kernel-team@android.com Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 05:47:33PM -0700, Isaac Manjarres wrote: > On Mon, Jul 18, 2022 at 06:53:43PM +0100, Catalin Marinas wrote: > > So do I but holidays get in the way ;). I plan to refresh my kmalloc > > minalign series at the end of August. > > > > One significant change I have though is that now ARCH_KMALLOC_MINALIGN > > now goes down all the way to 8 and using swiotlb bounce buffering if the > > DMA mapping size is small. > > This sounds like a good idea for optimizing kmalloc's memory usage > beyond what this series originally achieved. I'm sure a few other things > have come up in the meantime, but I was curious to know if you had a > chance to get back to this? I started refreshing the series but I got stuck on having to do bouncing for small buffers even if when they go through the iommu (and I don't have the set up to test it yet). I hope to post something when the merging window closes. In the meantime, I pushed my work-in-progress patches to: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux devel/kmalloc-minalign-v2-wip Apart from the iommu think, I still need to figure out whether with an ARCH_DMA_MINALIGN of 128 we need to disable the kmalloc-192 cache (so far I don't think it's needed). There are no additional changes to the crypto code from the last series, I still set CRYPTO_MINALIGN to ARCH_DMA_MINALIGN (without any other patches, crypto DMA will break; so I need to see how it interacts with Herbert's series). Anyway, I hope for more discussions once 6.1-rc1 is out. -- Catalin