From: Borislav Petkov <bp@alien8.de>
To: Evgeniy Baskov <baskov@ispras.ru>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>
Subject: Re: [PATCH v6 2/5] x86: Add cmdline_prepare() helper
Date: Fri, 30 Sep 2022 19:30:31 +0200 [thread overview]
Message-ID: <Yzcnt2oDiGHo10kP@zn.tnic> (raw)
In-Reply-To: <fc6713d1cb670313cdb61cc6f929dddc110f25d9.1661565218.git.baskov@ispras.ru>
On Sat, Aug 27, 2022 at 05:08:07AM +0300, Evgeniy Baskov wrote:
> +/*
> + * command_line and boot_command_line are expected to be at most
> + * COMMAND_LINE_SIZE length. command_line needs to be initialized
> + * with COMMAND_LINE_INIT.
> + */
> +static inline void cmdline_prepare(char *command_line,
> + const char *boot_command_line)
> +{
> +#ifdef CONFIG_CMDLINE_BOOL
Right, this is an ifdef...
> + if (!IS_ENABLED(CONFIG_CMDLINE_OVERRIDE)) {
... but this is a IS_ENABLED().
Why?
I think we should stick to one.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-09-30 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 2:08 [PATCH v6 0/5] Parse CONFIG_CMDLINE in compressed kernel Evgeniy Baskov
2022-08-27 2:08 ` [PATCH v6 1/5] x86/boot: Add strlcat() and strscpy() to " Evgeniy Baskov
2022-08-27 2:08 ` [PATCH v6 2/5] x86: Add cmdline_prepare() helper Evgeniy Baskov
2022-09-30 17:30 ` Borislav Petkov [this message]
2022-10-04 12:33 ` Evgeniy Baskov
2022-08-27 2:08 ` [PATCH v6 3/5] x86/setup: Use cmdline_prepare() in setup.c Evgeniy Baskov
2022-08-27 2:08 ` [PATCH v6 4/5] x86/boot: Use cmdline_prapare() in compressed kernel Evgeniy Baskov
2022-08-27 2:08 ` [PATCH v6 5/5] x86/boot: Remove no longer needed includes Evgeniy Baskov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzcnt2oDiGHo10kP@zn.tnic \
--to=bp@alien8.de \
--cc=baskov@ispras.ru \
--cc=dave.hansen@linux.intel.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox