From: Jason Gunthorpe <jgg@ziepe.ca>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: Bob Pearson <rpearsonhpe@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, Zhu Yanjun <zyjzyj2000@gmail.com>,
yangx.jy@fujitsu.com, y-goto@fujitsu.com, mbloch@nvidia.com,
liangwenpeng@huawei.com, tom@talpey.com,
tomasz.gromadzki@intel.com, dan.j.williams@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [for-next PATCH v5 03/11] RDMA: Extend RDMA kernel verbs ABI to support flush
Date: Fri, 30 Sep 2022 15:04:50 -0300 [thread overview]
Message-ID: <Yzcvwlq9QcssgDjJ@ziepe.ca> (raw)
In-Reply-To: <942fdca3-2cd4-88d2-033c-6bd3f7bb258a@fujitsu.com>
On Thu, Sep 29, 2022 at 02:21:24PM +0800, Li Zhijian wrote:
> we can see, IBV_ACCESS_REMOTE_ATOMIC and IBV_ACCESS_ON_DEMAND are
> tagged "if supported" . but currently kernel just returns EINVAL
> when user registers a MR with IB_ACCESS_ON_DEMAND to RXE.
>
> I wonder we should return -EOPNOTSUPP if the device doesn't support requested capabilities
Yes, unsupported combinations of access flags should trigger
EOPNOTSUPP
Jason
next prev parent reply other threads:[~2022-09-30 18:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 5:53 [for-next PATCH v5 00/11] RDMA/rxe: Add RDMA FLUSH operation Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 01/11] RDMA/rxe: make sure requested access is a subset of {mr,mw}->access Li Zhijian
2022-10-28 17:45 ` Jason Gunthorpe
2022-09-27 5:53 ` [for-next PATCH v5 02/11] RDMA: Extend RDMA user ABI to support flush Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 03/11] RDMA: Extend RDMA kernel verbs " Li Zhijian
2022-09-29 6:21 ` Li Zhijian
2022-09-30 18:04 ` Jason Gunthorpe [this message]
2022-10-28 17:44 ` Jason Gunthorpe
2022-10-29 3:15 ` Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 04/11] RDMA/rxe: Extend rxe user " Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 05/11] RDMA/rxe: Allow registering persistent flag for pmem MR only Li Zhijian
2022-10-28 17:53 ` Jason Gunthorpe
2022-10-30 3:33 ` Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 06/11] RDMA/rxe: Extend rxe packet format to support flush Li Zhijian
2022-11-11 8:43 ` Yanjun Zhu
2022-11-11 8:55 ` lizhijian
2022-11-11 9:28 ` Yanjun Zhu
2022-09-27 5:53 ` [for-next PATCH v5 07/11] RDMA/rxe: Implement RC RDMA FLUSH service in requester side Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 08/11] RDMA/rxe: Implement flush execution in responder side Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 09/11] RDMA/rxe: Implement flush completion Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 10/11] RDMA/cm: Make QP FLUSHABLE Li Zhijian
2022-09-27 5:53 ` [for-next PATCH v5 11/11] RDMA/rxe: Enable RDMA FLUSH capability for rxe device Li Zhijian
2022-10-28 17:44 ` [for-next PATCH v5 00/11] RDMA/rxe: Add RDMA FLUSH operation Jason Gunthorpe
2022-10-28 17:57 ` Jason Gunthorpe
2022-11-11 2:49 ` Yanjun Zhu
2022-11-11 5:10 ` lizhijian
2022-11-11 5:52 ` Yanjun Zhu
2022-11-11 6:10 ` lizhijian
2022-11-11 6:30 ` Yanjun Zhu
2022-11-11 6:38 ` lizhijian
2022-11-11 7:08 ` Yanjun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzcvwlq9QcssgDjJ@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dan.j.williams@intel.com \
--cc=leon@kernel.org \
--cc=liangwenpeng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=mbloch@nvidia.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox