Re: [PATCH 1/1] net: fec: using page pool to manage RX buffers

Andrew Lunn
2022-09-30T20:05:20Z

> -static bool fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> - struct bufdesc *bdp, u32 length, bool swap)
> +static bool __maybe_unused
> +fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> + struct bufdesc *bdp, u32 length, bool swap)
> {

Why add __maybe_unused? If its not used, remove it. We don't leave
dead functions in the code.

Andrew