From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] tpm: st33zp24: drop support for platform data
Date: Fri, 30 Sep 2022 23:39:06 +0300 [thread overview]
Message-ID: <YzdT6kkPXSXZ9hdB@kernel.org> (raw)
In-Reply-To: <20220926053958.1541912-1-dmitry.torokhov@gmail.com>
On Sun, Sep 25, 2022 at 10:39:56PM -0700, Dmitry Torokhov wrote:
> There are no users of st33zp24_platform_data in mainline, and new boards
> should be using device tree or ACPI to describe resources, so let's drop
> support for platform data from the driver.
Nit: drop instead of let's drop (needs also different sentence structure
obviously).
Also, please leave predictions out, or back them up with data. It's good
enough reason to remove code, if it is not used for anything. I really
don't care about "should" part. It is is out-of-scope for a kernel
patch.
BR, Jarkko
next prev parent reply other threads:[~2022-09-30 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 5:39 [PATCH 1/3] tpm: st33zp24: drop support for platform data Dmitry Torokhov
2022-09-26 5:39 ` [PATCH 2/3] tpm: st33zp24: switch to using gpiod API Dmitry Torokhov
2022-09-30 20:43 ` Jarkko Sakkinen
2022-09-26 5:39 ` [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe Dmitry Torokhov
2022-09-30 20:44 ` Jarkko Sakkinen
2022-10-01 4:13 ` Dmitry Torokhov
2022-09-30 20:39 ` Jarkko Sakkinen [this message]
2022-10-01 4:11 ` [PATCH 1/3] tpm: st33zp24: drop support for platform data Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzdT6kkPXSXZ9hdB@kernel.org \
--to=jarkko@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox